Return-Path: From: Szymon Janc To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] android/gatt: Fix dead code warnings Date: Fri, 19 Dec 2014 11:15:43 +0100 Message-ID: <1971447.3gPWfdfUJW@uw000953> In-Reply-To: <20141219101448.GA5094@aemeltch-MOBL1> References: <1418981080-19796-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <1729627.57WACxufJO@uw000953> <20141219101448.GA5094@aemeltch-MOBL1> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, On Friday 19 of December 2014 12:14:50 Andrei Emeltchenko wrote: > Hi Szymon, > > On Fri, Dec 19, 2014 at 11:07:55AM +0100, Szymon Janc wrote: > > Hi Andrei, > > > > On Friday 19 of December 2014 11:24:40 Andrei Emeltchenko wrote: > > > From: Andrei Emeltchenko > > > > > > gatt_db_attribute_get_permissions() used everywhere without check since > > > those conditions are checked already. > > > --- > > > android/gatt.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/android/gatt.c b/android/gatt.c > > > index 0258d91..169f6db 100644 > > > --- a/android/gatt.c > > > +++ b/android/gatt.c > > > @@ -6311,8 +6311,7 @@ static void write_cmd_request(const uint8_t *cmd, uint16_t cmd_len, > > > if (!attrib) > > > return; > > > > > > - if (!gatt_db_attribute_get_permissions(attrib, &permissions)) > > > - return; > > > + gatt_db_attribute_get_permissions(attrib, &permissions); > > > > > > if (check_device_permissions(dev, cmd[0], permissions)) > > > return; > > > > Wasn't identical patch already reviewed few weeks ago? > > > > It is still valid. No better approach was found. I suggested possible solution which you implemented in V2. But you seem to ignored comment from Luiz so this didn't moved on. -- Best regards, Szymon Janc