Return-Path: From: Szymon Janc To: Gowtham Anandha Babu Cc: linux-bluetooth@vger.kernel.org, d.kasatkin@samsung.com, bharat.panda@samsung.com, cpgs@samsung.com Subject: Re: [PATCH ] android/socket: Add PBAP supported features bits Date: Tue, 09 Dec 2014 14:24:15 +0100 Message-ID: <157571858.6JfrHtjm1y@leonov> In-Reply-To: <1418129488-12353-1-git-send-email-gowtham.ab@samsung.com> References: <1418129488-12353-1-git-send-email-gowtham.ab@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Gowtham, On Tuesday 09 of December 2014 18:21:27 Gowtham Anandha Babu wrote: > Add PBAP supported features in sdp record. Isn't that a 1.2 feature? (AOSP supports only 1.1). Same goes with MAP. > --- > android/socket.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/android/socket.c b/android/socket.c > index 2b836e9..f2cfd07 100644 > --- a/android/socket.c > +++ b/android/socket.c > @@ -58,6 +58,8 @@ > /* Hardcoded MAP stuff needed for MAS SMS Instance.*/ > #define DEFAULT_MAS_INSTANCE 0x00 > > +#define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003 > + > #define MAP_MSG_TYPE_SMS_GSM 0x02 > #define MAP_MSG_TYPE_SMS_CDMA 0x04 > #define DEFAULT_MAS_MSG_TYPE (MAP_MSG_TYPE_SMS_GSM | MAP_MSG_TYPE_SMS_CDMA) > @@ -287,6 +289,7 @@ static sdp_record_t *create_pbap_record(uint8_t chan, > const char *svc_name) sdp_list_t *seq; > sdp_profile_desc_t profile[1]; > uint8_t formats = 0x01; > + uint8_t supft = DEFAULT_PBAP_SUPPORTED_FEATURES; > sdp_record_t *record; > uuid_t uuid; > > @@ -304,6 +307,9 @@ static sdp_record_t *create_pbap_record(uint8_t chan, > const char *svc_name) sdp_attr_add_new(record, > SDP_ATTR_SUPPORTED_REPOSITORIES, SDP_UINT8, &formats); > > + sdp_attr_add_new(record, SDP_ATTR_PBAP_SUPPORTED_FEATURES, SDP_UINT32, > + &supft); > + > sdp_list_free(seq, NULL); > > return record; -- BR Szymon Janc