Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1417622074-20023-1-git-send-email-stevenrwalter@gmail.com> <1417622074-20023-3-git-send-email-stevenrwalter@gmail.com> From: Steven Walter Date: Wed, 3 Dec 2014 12:24:05 -0500 Message-ID: Subject: Re: [PATCH BlueZ 3/5] tools/btgatt-server.c: convert to glib mainloop To: Arman Uguray Cc: BlueZ development Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Wed, Dec 3, 2014 at 11:17 AM, Arman Uguray wrote: > Hi Steven, > >> On Wed, Dec 3, 2014 at 7:54 AM, Steven Walter wrote: >> Prep work for running gatt-dbus services >> --- >> Makefile.tools | 4 +- >> tools/btgatt-server.c | 136 ++++++++++++++++++++++++++------------------------ >> 2 files changed, 72 insertions(+), 68 deletions(-) >> >> diff --git a/Makefile.tools b/Makefile.tools >> index ef4162b..7520ab5 100644 >> --- a/Makefile.tools >> +++ b/Makefile.tools >> @@ -277,8 +277,8 @@ tools_btgatt_client_LDADD = src/libshared-mainloop.la \ >> lib/libbluetooth-internal.la >> >> tools_btgatt_server_SOURCES = tools/btgatt-server.c src/uuid-helper.c >> -tools_btgatt_server_LDADD = src/libshared-mainloop.la \ >> - lib/libbluetooth-internal.la >> +tools_btgatt_server_LDADD = lib/libbluetooth-internal.la src/libshared-glib.la \ >> + @GLIB_LIBS@ >> > > I'm not sure if this is something that we want. We've been using > monitor/mainloop in the newer tools as its more lightweight than glib. > I also don't see how gatt-dbus really fits into the scope of this > tool. The problem is probably that I don't understand the scope of the tool. Given its generic name, I was thinking that one would use btgatt-server to expose any kind of GATT attribute, in-process or not. Would it make more sense for there to be a stand-alone tool for publishing the GattManager1 D-Bus service? -- -Steven Walter