Return-Path: From: Arman Uguray To: linux-bluetooth@vger.kernel.org Cc: luiz.dentz@gmail.com, Arman Uguray Subject: [PATCH BlueZ v1 3/5] core: gatt: Implement GattCharacteristic1.StopNotify Date: Thu, 29 Jan 2015 15:15:11 -0800 Message-Id: <1422573313-30825-4-git-send-email-armansito@chromium.org> In-Reply-To: <1422573313-30825-1-git-send-email-armansito@chromium.org> References: <1422573313-30825-1-git-send-email-armansito@chromium.org> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: This patch implements the StopNotify method of org.bluez.GattCharacteristic1. --- src/gatt-client.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/gatt-client.c b/src/gatt-client.c index 4f5022a..e157ac2 100644 --- a/src/gatt-client.c +++ b/src/gatt-client.c @@ -1163,8 +1163,25 @@ static DBusMessage *characteristic_start_notify(DBusConnection *conn, static DBusMessage *characteristic_stop_notify(DBusConnection *conn, DBusMessage *msg, void *user_data) { - /* TODO: Implement */ - return btd_error_failed(msg, "Not implemented"); + struct characteristic *chrc = user_data; + struct bt_gatt_client *gatt = chrc->service->client->gatt; + const char *sender = dbus_message_get_sender(msg); + struct notify_client *client; + + if (!chrc->notifying) + return btd_error_failed(msg, "Not notifying"); + + client = queue_remove_if(chrc->notify_clients, match_notify_sender, + (void *) sender); + if (!client) + return btd_error_failed(msg, "No notify session started"); + + bt_gatt_client_unregister_notify(gatt, client->notify_id); + update_notifying(chrc); + + notify_client_unref(client); + + return dbus_message_new_method_return(msg); } static void append_desc_path(void *data, void *user_data) -- 2.2.0.rc0.207.ga3a616c