Return-Path: MIME-Version: 1.0 Sender: armansito@google.com In-Reply-To: <938707CA-DE91-41D5-B611-B89CFF9236C6@holtmann.org> References: <1424927610-26226-1-git-send-email-armansito@chromium.org> <1424927610-26226-4-git-send-email-armansito@chromium.org> <938707CA-DE91-41D5-B611-B89CFF9236C6@holtmann.org> Date: Thu, 26 Feb 2015 12:32:45 -0800 Message-ID: Subject: Re: [PATCH BlueZ v1 03/17] gdbus/client: Allow specifying ObjectManager path From: Arman Uguray To: Marcel Holtmann Cc: BlueZ development Content-Type: text/plain; charset=UTF-8 List-ID: Hi Marcel, > On Thu, Feb 26, 2015 at 7:38 AM, Marcel Holtmann wrote: > Hi Arman, > >> GDBusClient currently hard-codes "/" as the remote ObjectManager path. >> This is generally incorrect, as an application can choose to expose an >> ObjectManager at any well-known path. This patch fixes this by allowing >> the user to pass in the ObjectManager path to g_dbus_client_new. >> --- >> client/main.c | 2 +- >> gdbus/client.c | 23 ++++++++++++++++------- >> gdbus/gdbus.h | 5 +++-- >> plugins/hostname.c | 2 +- >> profiles/iap/main.c | 2 +- >> tools/bluetooth-player.c | 2 +- >> tools/gap-tester.c | 3 ++- >> tools/gatt-service.c | 2 +- >> tools/mpris-proxy.c | 2 +- >> tools/obexctl.c | 2 +- >> unit/test-gdbus-client.c | 39 ++++++++++++++++++++++++++------------- >> 11 files changed, 54 insertions(+), 30 deletions(-) > > please to not intermix gdbus/ changes with others. Everything in gdbus/ needs to be a separate patch. You are affecting more than one project here. > This is a gdbus/ only change but I it changes an API definition so all of these other spots need to be updated otherwise the code won't compile. > Regards > > Marcel > Arman