Return-Path: <cyrus@holtmann.org>
MIME-Version: 1.0
In-Reply-To: <1427340597-8193-2-git-send-email-armansito@chromium.org>
References: <1427340597-8193-1-git-send-email-armansito@chromium.org>
	<1427340597-8193-2-git-send-email-armansito@chromium.org>
Date: Wed, 25 Mar 2015 20:37:53 -0700
Message-ID: <CAHrH25T=G8C5DQopAgidnsLGgXyLjvSoJWg1uxWY16iRXAPanA@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] tools/btmgmt: Better usage info for add-adv
From: Arman Uguray <armansito@chromium.org>
To: BlueZ development <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi,

> On Wed, Mar 25, 2015 at 8:29 PM, Arman Uguray <armansito@chromium.org> wrote:
> This patch improves the usage string that gets printed for the add-adv
> command to provide more details about the possible options.
> ---
>  tools/btmgmt.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/tools/btmgmt.c b/tools/btmgmt.c
> index 19eeda1..bd83ac7 100644
> --- a/tools/btmgmt.c
> +++ b/tools/btmgmt.c
> @@ -3687,8 +3687,18 @@ static void add_adv_rsp(uint8_t status, uint16_t len, const void *param,
>
>  static void add_adv_usage(void)
>  {
> -       print("Usage: add-adv [-u uuid] [-d adv_data] [-s scan_rsp] "
> -               "[-t timeout] [-c] [-d] [-e] [-l] [-m] [-p] <instance_id>");
> +       print("Usage: add-adv [options] <instance_id>\nOptions:\n"
> +               "\t -u, --uuid <uuid>        Service UUID\n"
> +               "\t -d, --adv-data <data>    Advertising Data bytes\n"
> +               "\t -s, --scan-rsp <data>    Scan Response Data bytes\n"
> +               "\t -t, --timeout <timeout>  Timeout in seconds\n"
> +               "\t -c, --connectable        \"connectable\" flag\n"
> +               "\t -g, --general-discov     \"general-discoverable\" flag\n"
> +               "\t -l, --limited-discov     \"limited-discoverable\" flag\n"
> +               "\t -m, --managed-flags      \"managed-flags\" flag\n"
> +               "\t -p, --tx-power           \"tx-power\" flag\n"
> +               "e.g.:\n"
> +               "\tadd-adv -u 180d -u 180f -d 080954657374204C45 1");
>  }
>
>  static struct option add_adv_options[] = {
> --
> 2.2.0.rc0.207.ga3a616c
>

All 4 patches in this set have been applied.

Thanks,
Arman