Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: [PATCH 1/7] Bluetooth: Add macros for advertising instance flags From: Marcel Holtmann In-Reply-To: <1427252582-24814-1-git-send-email-armansito@chromium.org> Date: Wed, 25 Mar 2015 09:21:13 -0700 Cc: linux-bluetooth@vger.kernel.org Message-Id: References: <1427252582-24814-1-git-send-email-armansito@chromium.org> To: Arman Uguray Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Arman, > This patch adds macro definitions for possible advertising instance > flags that can be passed to the "Add Advertising" command. > > Signed-off-by: Arman Uguray > --- > include/net/bluetooth/mgmt.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h > index 68abd4b..fc50cee 100644 > --- a/include/net/bluetooth/mgmt.h > +++ b/include/net/bluetooth/mgmt.h > @@ -554,6 +554,14 @@ struct mgmt_rp_add_advertising { > __u8 instance; > } __packed; > > +#define MGMT_ADV_FLAG_CONNECTABLE (1 << 0) > +#define MGMT_ADV_FLAG_DISCOV (1 << 1) > +#define MGMT_ADV_FLAG_LIMITED_DISCOV (1 << 2) > +#define MGMT_ADV_FLAG_MANAGED_FLAGS (1 << 3) > +#define MGMT_ADV_FLAG_TX_POWER (1 << 4) > +#define MGMT_ADV_FLAG_APPEARANCE (1 << 5) > +#define MGMT_ADV_FLAG_LOCAL_NAME (1 << 6) > + any reason to not use BIT(0) etc. here. Regards Marcel