Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1429319372-25172-1-git-send-email-jpawlowski@google.com> Date: Thu, 23 Apr 2015 08:56:47 -0700 Message-ID: Subject: Re: [PATCH 1/3] doc/device-api: Add TxPower From: Jakub Pawlowski To: Luiz Augusto von Dentz Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Ping ? On Mon, Apr 20, 2015 at 8:55 AM, Jakub Pawlowski wrote: > Hi Luiz > > On Mon, Apr 20, 2015 at 7:32 AM, Luiz Augusto von Dentz > wrote: >> Hi Jakub, >> >> On Sat, Apr 18, 2015 at 4:09 AM, Jakub Pawlowski wrote: >>> This adds TxPower from advertisement data. >>> >>> Signed-off-by: Jakub Pawlowski >>> --- >>> doc/device-api.txt | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/doc/device-api.txt b/doc/device-api.txt >>> index 72c597e..875fd9d 100644 >>> --- a/doc/device-api.txt >>> +++ b/doc/device-api.txt >>> @@ -196,6 +196,11 @@ Properties string Address [readonly] >>> Received Signal Strength Indicator of the remote >>> device (inquiry or advertising). >>> >>> + int16 TxPower [readonly, optional] >>> + >>> + Advertised transmitted power level (inquiry or >>> + advertising). >>> + >>> dict ManufacturerData [readonly, optional] >>> >>> Manufacturer specific advertisement data. Keys are >>> -- >>> 2.2.0.rc0.207.ga3a616c >> >> I thought we discussed about this before and we would like to have the >> pathloss instead of TxPower, or do you have something else useful for >> TxPower? > > I don't remember such discussion, I remember we were discussing about > SetDiscoveryFilter, and it have option to filter by pathloss. > So I exposed TxPower for two reasons: > 1. It's just a field in advertisement, and I wanted just to access it > as any other. > 2. If I turn it into Pathloss field, it would change together with > RSSI, and PropertyChanged event will be doubled. Pathloss is very > simple to compute, so having only RSSI that change is more efficient. > > >> >> >> -- >> Luiz Augusto von Dentz