Return-Path: MIME-Version: 1.0 In-Reply-To: <300602D8-9DB7-4F8D-AC97-B60924554093@holtmann.org> References: <300602D8-9DB7-4F8D-AC97-B60924554093@holtmann.org> Date: Fri, 17 Apr 2015 18:55:49 +0200 Message-ID: Subject: Re: [V4.1] Regression: Bluetooth mouse not working. From: =?UTF-8?Q?J=C3=B6rg_Otte?= To: Marcel Holtmann Cc: Linus Torvalds , "Gustavo F. Padovan" , Johan Hedberg , "bluez mailin list (linux-bluetooth@vger.kernel.org)" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 List-ID: 2015-04-17 18:51 GMT+02:00 Marcel Holtmann : > Hi Joerg, > >>>> On Fri, Apr 17, 2015 at 5:36 AM, J=C3=B6rg Otte w= rote: >>>>> The BT mouse is "death" in v4.1. >>>>> The BT mouse has been working in 4.0 and previous kernels, so this >>>>> is a regression. >>>> >>>> Any chance of bisecting it? >>>> >>>> Linus >>> I will try that. >>> >>> Thanks, J=C3=B6rg >> >> I first tried to bisect over all. But than I got an unbootable kernel. >> Then I did a bisect over net/bluetooth and I get the following fist bad >> commit: >> >> 5f5da99f1da5b01c7c45473a500c7dbb77a00958 is the first bad commit >> commit 5f5da99f1da5b01c7c45473a500c7dbb77a00958 >> Author: Marcel Holtmann >> Date: Wed Apr 1 13:51:53 2015 -0700 >> >> Bluetooth: Restrict HIDP flags to only valid ones >> >> The HIDP flags should be clearly restricted to valid ones. So this pu= ts >> extra checks in place to ensure this. >> >> Signed-off-by: Marcel Holtmann >> Signed-off-by: Johan Hedberg >> >> :040000 040000 b51ac3634c9d44f4d9df0e7f548b524954b99c76 >> 63bfb47283609849f1b3b8f05fe61743ccddfee6 M net > > thanks for bi-secting this. I looked at our existing userspace and restri= cted it to the flags that are currently in use. However it seems that I mad= e a mistake. What version of BlueZ userspace are you using (bluetoothd --ve= rsion). > > Regards > > Marcel > bluetoothd --version 4.98 Thanks, J=C3=B6rg