Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: [PATCH ] tools/hciconfig: Configure LE adv data flags From: Marcel Holtmann In-Reply-To: <00f201d0711a$15959f80$40c0de80$@samsung.com> Date: Tue, 7 Apr 2015 08:12:28 -0700 Cc: BlueZ development , cpgs@samsung.com Message-Id: <8F0DB5E0-9B9B-4212-BEB4-649E8859E010@holtmann.org> References: <1428315384-4984-1-git-send-email-bharat.panda@samsung.com> <98490C74-4CA7-446A-A024-A270D63F0BA9@holtmann.org> <00f201d0711a$15959f80$40c0de80$@samsung.com> To: Bharat Bhusan Panda Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Bharat, >>> Add support for LE advertisement data flags by adding a new command in >>> hciconfig tool "leadvflags". >>> >>> LE adv flag values can be refered from CSS 5, section 1.3.2, formats. >>> --- >>> tools/hciconfig.c | 121 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 121 insertions(+) >> >> this does not look like a useful addition to me. We have a proper mgmt >> support for LE advertising and this is just not helpful. You can achieve > the >> same with a hcitool cmd execution. Especially since there is no guarantee >> that the advertising data will be overwritten by the kernel at any point > in >> time. The kernel can not preserve data injected on HCI from userspace. >> > Yes, I can get the same through hcitool too, thanks. > I have one query, in hciconfig, we can set "Non connectable undirected > advertising" in "leadv" command. Is there any way, we can set "connectable > undirected advertising with random address type" through any of the tools? the kernel will do the right thing for you depending on your settings. A LE only configured controller with a static address will use random address type, LE privacy enabled devices will use a RPA and if connectable is not set a NRPA will be used. Regards Marcel