Return-Path: Message-ID: <551EA13B.7010307@intel.com> Date: Fri, 03 Apr 2015 16:18:35 +0200 From: Loic Poulain MIME-Version: 1.0 To: Peter Hurley , Frederic Danis CC: linux-bluetooth@vger.kernel.org, gregkh@linuxfoundation.org, jslaby@suse.cz Subject: Re: [RFC 3/5] Bluetooth: hci_uart: Add HCIUARTSETBAUDRATE ioctl References: <1427985456-31536-1-git-send-email-frederic.danis@linux.intel.com> <1427985456-31536-4-git-send-email-frederic.danis@linux.intel.com> <551E717A.6040500@hurleysoftware.com> <551E8C6A.8040009@linux.intel.com> <551E9987.9050800@hurleysoftware.com> In-Reply-To: <551E9987.9050800@hurleysoftware.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Peter, On 03/04/2015 15:45, Peter Hurley wrote: > The line discipline is always notified of line rate changes > via the set_termios() method, so if you add that to the hci_ldisc, > you'll be able to keep the BT device in sync with your > vendor-specific commands. If I'm not wrong, line discipline is notified after the tty termios change. So, it's too late to send the HCI change speed command. Moreover, user space is not aware of the device behavior, the driver should be the only one to manage the device and its serial link. Here, user space is just a bootstrap which hands over to the driver. Regards, Loic -- Intel Open Source Technology Center http://oss.intel.com/