Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [PATCH v5 2/4] Bluetooth: btusb: Fix calls to __hci_cmd_sync() From: Marcel Holtmann In-Reply-To: <1431683922-20418-2-git-send-email-frederic.danis@linux.intel.com> Date: Fri, 15 May 2015 16:06:57 +0200 Cc: linux-bluetooth@vger.kernel.org Message-Id: <64A46F1C-BD2E-4446-BE23-A1C139ED3A9E@holtmann.org> References: <1431683922-20418-1-git-send-email-frederic.danis@linux.intel.com> <1431683922-20418-2-git-send-email-frederic.danis@linux.intel.com> To: Frederic Danis Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Fred, > Remove test of command reply status as it is already performed by > __hci_cmd_sync(). > > __hci_cmd_sync_ev() function already returns an error if it got a > non-zero status either through a Command Complete or a Command > Status event. > > For both of these events the status is collected up in the event > handlers called by hci_event_packet() and then passed as the second > parameter to req_complete_skb(). The req_complete_skb() callback in > turn is hci_req_sync_complete() for __hci_cmd_sync_ev() which stores > the status in hdev->req_result. The hdev->req_result is then further > converted through bt_to_errno() back in __hci_cmd_sync_ev(). > > Signed-off-by: Frederic Danis > --- > drivers/bluetooth/btusb.c | 36 ------------------------------------ > 1 file changed, 36 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel