Return-Path: <cyrus@holtmann.org>
Date: Thu, 18 Jun 2015 13:19:25 +0300
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Florian Grandel <fgrandel@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [BlueZ v9 00/16] Multi-advertising
Message-ID: <20150618101925.GA23178@t440s.lan>
References: <1434166979-21824-1-git-send-email-fgrandel@gmail.com>
 <1434590266-26744-1-git-send-email-fgrandel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1434590266-26744-1-git-send-email-fgrandel@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Florian,

On Thu, Jun 18, 2015, Florian Grandel wrote:
> patch set accompanying the introduction of a multi-advertising
> infrastructure in the kernel
> 
> v1 ... v4:
> - fix tests to test for correct behavior when removing all adv instances
>   by passing in the 0x00 instance identifier
> 
> v4 -> v5:
> - factored userland code changes into a separate change set for easier
>   review
> 
> v5 -> v6:
> - documented add advertising test setup
> - renamed add advertising tests to make them more readable
> - added test to reproduce a bug found by Marcel (executing add-adv twice
>   for the same instance should override the adv data)
> 
> v6 -> v7:
> - correctly split mangled patches
> 
> v7 -> v8:
> - several additional test documentation improvements
> - documenting multi-adv implementation details in the mgmt api doc
> - made the debugging of cmd response messages easier
> - made the duration parameter accessible via btmgmt
> - provided test infrastructure for timed tests
> - fix duplicate code
> - fix a few typos
> - added test for advertising timeout
> - added test for le off
> - added multi-adv tests
> 
> v8 -> v9 (due to Marcel's review):
> - improved and fixed changes to mgmt-api.txt
> - added a test that guarantees that instances without a timeout survive
>   a power cycle
> 
> Florian Grandel (16):
>   doc/mgmt-api: multi-adv implementation details
>   doc/mgmt-api: fix typos
>   tools/btmgmt: make inst duration configurable
>   tools/mgmt-tester: error message when unexp params
>   tools/mgmt-tester: expect 0 rp when removing all adv inst
>   tools/mgmt-tester: comment add adv test setup
>   tools/mgmt-tester: rename add adv tests
>   tools/mgmt-tester: increase max adv inst
>   tools/mgmt-tester: keep instances on power cycle
>   tools/mgmt-tester: test adv inst override
>   tools/mgmt-tester: make test timeout configurable
>   tools/mgmt-tester: allow for event-only tests
>   tools/mgmt-tester: test advertising timeout
>   tools/mgmt-tester: test le off
>   tools/mgmt-tester: fix duplicate code
>   tools/mgmt-tester: test multi-adv
> 
>  doc/mgmt-api.txt      | 105 +++++--
>  doc/test-coverage.txt |   4 +-
>  tools/btmgmt.c        |  28 +-
>  tools/mgmt-tester.c   | 838 +++++++++++++++++++++++++++++++++++---------------
>  4 files changed, 681 insertions(+), 294 deletions(-)

All patches in this set have been applied. Thanks!

Johan