Return-Path: From: Ilya Faenson To: Marcel Holtmann CC: "linux-bluetooth@vger.kernel.org" , "Arend Van Spriel" Subject: RE: [PATCH v2 1/5] Broadcom Bluetooth UART Device Tree bindings Date: Fri, 12 Jun 2015 16:51:01 +0000 Message-ID: References: <1433966720-17482-1-git-send-email-ifaenson@broadcom.com> <1433966720-17482-2-git-send-email-ifaenson@broadcom.com> <4C76A9C6-BF09-4099-A4C6-BB5E54FEA31F@holtmann.org> In-Reply-To: <4C76A9C6-BF09-4099-A4C6-BB5E54FEA31F@holtmann.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: Hi Marcel, -----Original Message----- From: Marcel Holtmann [mailto:marcel@holtmann.org]=20 Sent: Friday, June 12, 2015 11:39 AM To: Ilya Faenson Cc: linux-bluetooth@vger.kernel.org; Arend Van Spriel Subject: Re: [PATCH v2 1/5] Broadcom Bluetooth UART Device Tree bindings Hi Ilya, >> Device Tree bindings to configure the Broadcom Bluetooth UART device. >>=20 >> Signed-off-by: Ilya Faenson >> --- >> .../devicetree/bindings/net/bluetooth/btbcm.txt | 82 ++++++++++++++++= ++++++ >> 1 file changed, 82 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/btbcm= .txt >>=20 >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/btbcm.txt b= /Documentation/devicetree/bindings/net/bluetooth/btbcm.txt >> new file mode 100644 >> index 0000000..2679819 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/bluetooth/btbcm.txt >> @@ -0,0 +1,82 @@ >> +btbcm >> +------ >> + >> +Required properties: >> + >> + - compatible : must be "brcm,brcm-bt-uart". >> + - tty : tty device connected to this Bluetooth device. >> + >> +Optional properties: >> + >> + - bt-host-wake-gpios : bt-host-wake input GPIO to be used as an inter= rupt. >> + >> + - bt-wake-gpios : bt-wake output GPIO to be used to suspend / resume = device. >> + >> + - bt-reg-on-gpios : reg-on output GPIO to be used to power device on/= off. >> + >> + - oper-speed : Bluetooth device operational baud rate. >> + Default: 3000000. >> + >> + - manual-fc : flow control UART in suspend / resume scenarios. >> + Default: 0. >> + >> + - configure-sleep : configure suspend / resume flag. >> + Default: false. >> + >> + - configure-audio : configure platform PCM SCO flag. >> + Default: false. >> + >> + - pcm-clockmode : PCM clock mode. 0-slave, 1-master. >> + Default: 0. >> + >> + - pcm-fillmethod : PCM fill method. 0 to 3. >> + Default: 2. >> + >> + - pcm-fillnum : PCM number of fill bits. 0 to 3. >> + Default: 0. >> + >> + - pcm-fillvalue : PCM fill value. 0 to 7. >> + Default: 3. >> + >> + - pcm-incallbitclock : PCM interface rate. 0-128Kbps, 1-256Kbps, 2-51= 2Kbps, >> + 3-1024Kbps, 4-2048Kbps. >> + Default: 0. >> + >> + - pcm-lsbfirst : PCM LSB first. 0 or 1. >> + Default: 0. >> + >> + - pcm-rightjustify : PCM Justify. 0-left, 1-right. >> + Default: 0. >> + >> + - pcm-routing : PCM routing. 0-PCM, 1-SCO over HCI. >> + Default: 0. >> + >> + - pcm-shortframesync : PCM sync. 0-short, 1-long. >> + Default: 0. >> + >> + - pcmsyncmode : PCM sync mode. 0-slave, 1-master. >> + Default: 0. >=20 > I think you meant pcm-syncmode here. >=20 > IF: That's right, will change. >> + >> + >> +Example: >> + >> + brcm4354_bt_uart: brcm4354-bt-uart { >=20 > Since in general the chips and firmware name refer to BCM4354, it might b= e a really good idea to use bcm4354 here and not confuse people further. I = am just trying to avoid confusion here. >=20 > IF: You're right, the chip name is BCM4354 but we must use the "brcm" pre= fix in the device tree bindings. Alright, I will change these to start from= the "bcm" but will keep the "brcm" in the "compatible" strings. That would= also be somewhat confusing but possibly not as confusing as now. I think Arend had a good proposal there. If I remember correctly then when = it refers to Broadcom as generic DT identifier, then it is brcm. If it is d= evice specific use the actual name bcm1234. SO things like brcm,bcm1234 mad= e sense to at least me. IF: Agreed. Regards Marcel