Return-Path: <cyrus@holtmann.org>
From: Bharat Bhusan Panda <bharat.panda@samsung.com>
To: linux-bluetooth@vger.kernel.org
Cc: cpgs@samsung.com
References: <1433517215-25516-1-git-send-email-bharat.panda@samsung.com>
In-reply-to: <1433517215-25516-1-git-send-email-bharat.panda@samsung.com>
Subject: RE: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata
Date: Thu, 11 Jun 2015 11:14:28 +0530
Message-id: <046901d0a409$b48fac80$1daf0580$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

ping

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Bharat Panda
> Sent: Friday, June 05, 2015 8:44 PM
> To: linux-bluetooth@vger.kernel.org
> Cc: cpgs@samsung.com; Bharat Panda
> Subject: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata
> 
> Total Number of Tracks was not displayed, coz "Number of Tracks"
> was not handled in metadata parser.
> ---
>  profiles/audio/media.c | 3 +++
>  tools/mpris-proxy.c    | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/profiles/audio/media.c b/profiles/audio/media.c index
> f12569e..8e7e1a3 100644
> --- a/profiles/audio/media.c
> +++ b/profiles/audio/media.c
> @@ -1510,6 +1510,9 @@ static gboolean parse_player_metadata(struct
> media_player *mp,
>  		} else if (strcasecmp(key, "xesam:trackNumber") == 0) {
>  			if (!parse_int32_metadata(mp, "TrackNumber",
> &var))
>  				return FALSE;
> +		} else if (strcasecmp(key, "xesam:totalTracks") == 0) {
> +			if (!parse_int32_metadata(mp, "NumberOfTracks",
> &var))
> +				return FALSE;
>  		} else
>  			DBG("%s not supported, ignoring", key);
> 
> diff --git a/tools/mpris-proxy.c b/tools/mpris-proxy.c index
693055e..5749427
> 100644
> --- a/tools/mpris-proxy.c
> +++ b/tools/mpris-proxy.c
> @@ -1261,6 +1261,9 @@ static int parse_track_entry(DBusMessageIter
> *entry, const char *key,
>  	} else if (strcasecmp(key, "TrackNumber") == 0) {
>  		if (!parse_int32_metadata(&var, "xesam:trackNumber",
> metadata))
>  			return -EINVAL;
> +	} else if (strcasecmp(key, "NumberOfTracks") == 0) {
> +		if (!parse_int32_metadata(&var, "xesam:totalTracks",
> metadata))
> +			return -EINVAL;
>  	} else if (strcasecmp(key, "Item") == 0) {
>  		if (!parse_path_metadata(&var, "mpris:trackid", metadata))
>  			return -EINVAL;
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html