Return-Path: Date: Fri, 5 Jun 2015 16:00:06 +0300 From: Andrei Emeltchenko To: linux-bluetooth@vger.kernel.org Subject: Re: [PATCHv2] shared/att: Fix boolean check in handle_notify() Message-ID: <20150605130004.GA13309@comms> References: <1432889606-3967-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <20150601101141.GB31534@comms> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150601101141.GB31534@comms> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: ping On Mon, Jun 01, 2015 at 01:11:43PM +0300, Andrei Emeltchenko wrote: > ping > > On Fri, May 29, 2015 at 11:53:26AM +0300, Andrei Emeltchenko wrote: > > From: Andrei Emeltchenko > > > > ext_signed is boolean and shall be checked with logical op. > > --- > > src/shared/att.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/shared/att.c b/src/shared/att.c > > index 053aa47..f9a5817 100644 > > --- a/src/shared/att.c > > +++ b/src/shared/att.c > > @@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu, > > const struct queue_entry *entry; > > bool found; > > > > - if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) { > > + if ((opcode & ATT_OP_SIGNED_MASK) && !att->ext_signed) { > > if (!handle_signed(att, opcode, pdu, pdu_len)) > > return; > > pdu_len -= BT_ATT_SIGNATURE_LEN; > > -- > > 2.1.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html