Return-Path: Subject: Re: [RFC bluetooth-next 1/2] bluetooth: 6lowpan: change netdev_priv to lowpan_dev To: Alexander Aring , linux-wpan@vger.kernel.org References: <1438172674-31028-1-git-send-email-alex.aring@gmail.com> <1438172674-31028-2-git-send-email-alex.aring@gmail.com> <55BA7CB5.7030605@osg.samsung.com> Cc: kernel@pengutronix.de, linux-bluetooth@vger.kernel.org, lukasz.duda@nordicsemi.no From: Stefan Schmidt Message-ID: <55BA7D65.40202@osg.samsung.com> Date: Thu, 30 Jul 2015 21:39:17 +0200 MIME-Version: 1.0 In-Reply-To: <55BA7CB5.7030605@osg.samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hello. On 30/07/15 21:36, Stefan Schmidt wrote: > Hello. > > On 29/07/15 14:24, Alexander Aring wrote: >> The usually way to get the btle lowpan private data is to use the >> introduced lowpan_dev inline function. This patch will cleanup by using >> lowpan_dev consequently. >> >> Signed-off-by: Alexander Aring >> --- >> net/bluetooth/6lowpan.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c >> index 2fb7b30..93c6ba0 100644 >> --- a/net/bluetooth/6lowpan.c >> +++ b/net/bluetooth/6lowpan.c >> @@ -871,7 +871,7 @@ static int setup_netdev(struct l2cap_chan *chan, >> struct lowpan_dev **dev) >> &chan->src, chan->src_type); >> set_bit(__LINK_STATE_PRESENT, &netdev->state); >> - *dev = netdev_priv(netdev); >> + *dev = lowpan_dev(netdev); >> (*dev)->netdev = netdev; >> (*dev)->hdev = chan->conn->hcon->hdev; >> INIT_LIST_HEAD(&(*dev)->peers); > > This patch does no longer apply. There have been 5 patches to the > 6lowpan file in bluetooth from Gleen. You need to rebase this one. > Looking at it in more detail its actually your own patch which makes the rebase necessary. The one fixing a possible race. regards Stefan Schmidt