Return-Path: MIME-Version: 1.0 In-Reply-To: <004d01d0db48$6fe5be00$4fb13a00$@samsung.com> References: <1440061390-32664-1-git-send-email-bharat.panda@samsung.com> <004d01d0db48$6fe5be00$4fb13a00$@samsung.com> Date: Thu, 20 Aug 2015 16:23:25 +0300 Message-ID: Subject: Re: [PATCH 1/2] test: Add sample media player properties From: Luiz Augusto von Dentz To: Bharat Bhusan Panda Cc: "linux-bluetooth@vger.kernel.org" , cpgs@samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Bharat, On Thu, Aug 20, 2015 at 4:01 PM, Bharat Bhusan Panda wrote: > Hi Luiz, > >> -----Original Message----- >> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com] >> Sent: Thursday, August 20, 2015 6:19 PM >> To: Bharat Panda >> Cc: linux-bluetooth@vger.kernel.org; cpgs@samsung.com >> Subject: Re: [PATCH 1/2] test: Add sample media player properties >> >> Hi Bharat, >> >> On Thu, Aug 20, 2015 at 12:03 PM, Bharat Panda >> wrote: >> > Polulates media player properties with player name, type, sub-type and >> > features with sample values. >> > --- >> > test/simple-player | 4 ++++ >> > 1 file changed, 4 insertions(+) >> > >> > diff --git a/test/simple-player b/test/simple-player index >> > a8ae0b1..a89767a 100755 >> > --- a/test/simple-player >> > +++ b/test/simple-player >> > @@ -43,6 +43,10 @@ class Player(dbus.service.Object): >> > >> > self.properties = dbus.Dictionary({ >> > "PlaybackStatus" : "playing", >> > + "DisplayName" : "SimplePlayer", >> > + "Type" : "Audio", >> > + "SubType" : "Audio Book", >> > + "Features" : >> > + "0000000000b701ef0200000000000000", >> > "LoopStatus" : "None", >> > "Rate" : dbus.Double(1.0), >> > "Shuffle" : >> > dbus.Boolean(False), >> > -- >> > 1.9.1 >> >> This properties do not exist in MPRIS >> http://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html, >> for DisplayName you can probably use Identity but for other we might have >> to infer based on the available MPRIS properties. > So except DisplayName, others(type, sub-type and features) will be inferred. How about building response for GetFolderItems, as it needs all these player properties to be filled in response PDU? What shall be filled in there? For type and sub-type we could perhaps look at SupportedMimeTypes, we can assume it is at least audio type. For features there are some indication already what the player support in terms of key presses, etc and if NowPlaying is support with http://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:HasTrackList. >> >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe >> > linux-bluetooth" in the body of a message to majordomo@vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> >> -- >> Luiz Augusto von Dentz > > Regards, > Bharat > -- Luiz Augusto von Dentz