Return-Path: From: "Mutharaju, Prasanna (P.)" To: Szymon Janc CC: "marcel@holtmann.org" , "gustavo@padovan.org" , "johan.hedberg@gmail.com" , "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH] Bluetooth:hci_qca: Changed unsigned long to bool Date: Mon, 28 Sep 2015 07:58:52 +0000 Message-ID: <20150928075845.GA3321@jci-VirtualBox> References: <20150928062901.GA5935@jci-VirtualBox> <8697290.fIAsqDPKZQ@leonov> In-Reply-To: <8697290.fIAsqDPKZQ@leonov> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: On Mon, Sep 28, 2015 at 09:15:47AM +0200, Szymon Janc wrote: > Hi, >=20 > On Monday 28 of September 2015 06:29:07 Mutharaju, Prasanna wrote: > > From: Prasanna Karthik > >=20 > > 'retransmit' being set in HCI_IBS_TX_WAKING case, > > using bool would be efficient. > >=20 > > Signed-off-by: Prasanna Karthik > > --- > > drivers/bluetooth/hci_qca.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > > index 21f4ea4..3fdb17d 100644 > > --- a/drivers/bluetooth/hci_qca.c > > +++ b/drivers/bluetooth/hci_qca.c > > @@ -347,7 +347,7 @@ static void hci_ibs_wake_retrans_timeout(unsigned l= ong > > arg) struct hci_uart *hu =3D (struct hci_uart *)arg; > > struct qca_data *qca =3D hu->priv; > > unsigned long flags, retrans_delay; > > - unsigned long retransmit =3D 0; > > + bool retransmit; > >=20 > > BT_DBG("hu %p wake retransmit timeout in %d state", > > hu, qca->tx_ibs_state); > > @@ -358,7 +358,7 @@ static void hci_ibs_wake_retrans_timeout(unsigned l= ong > > arg) switch (qca->tx_ibs_state) { > > case HCI_IBS_TX_WAKING: > > /* No WAKE_ACK, retransmit WAKE */ > > - retransmit =3D 1; > > + retransmit =3D true; > > if (send_hci_ibs_cmd(HCI_IBS_WAKE_IND, hu) < 0) { > > BT_ERR("Failed to acknowledge device wake up"); > > break; >=20 > Isn't this patch giving you a warning about retransmit being used=20 > uninitialized? (it is never set to false) >=20 > --=20 > BR > Szymon Janc Nope, It doesn't show compiler warning, bool will be initialized to false by default by the compiler. I will send a V2 of the patch with retransmit set to false if needed. =