Return-Path: Subject: Re: [PATCH] Bluetooth: close HCI device when user channel socket gets closed To: Marcel Holtmann References: <1441188612-18946-1-git-send-email-simon.fels@canonical.com> Cc: linux-bluetooth@vger.kernel.org From: Simon Fels Message-ID: <55E737F7.8000303@canonical.com> Date: Wed, 2 Sep 2015 19:55:03 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed List-ID: On 02.09.2015 18:17, Marcel Holtmann wrote: > Hi Simon, > >> With 9380f9eacfbbee701daa416edd6625efcd3e29e1 the order of unsetting >> the HCI_USER_CHANNEL flag of the HCI device was reverted to ensure >> the device is first closed before making it available again. >> >> Due to hci_dev_close checking for HCI_USER_CHANNEL being set on the >> device it was never really closed and was kept opened. We're now >> calling hci_dev_do_close directly to make sure the device is correctly >> closed and we keep the correct order to unset the flag on our device >> object. >> >> Signed-off-by: Simon Fels >> --- >> include/net/bluetooth/hci_core.h | 1 + >> net/bluetooth/hci_core.c | 2 +- >> net/bluetooth/hci_sock.c | 2 +- >> 3 files changed, 3 insertions(+), 2 deletions(-) > > patch has been applied to bluetooth-next tree. Thanks a lot! > However I added an extra comment into the code on why this is actually doing the right thing in the end. I mentioned before that I failed to comment on this before and we do not want to keep forgetting to comment on code that is not intuitive. Yeah sorry.. forgot about this :) regards, Simon