Return-Path: Date: Tue, 13 Oct 2015 14:22:49 +0300 From: Heikki Krogerus To: Frederic Danis Cc: linux-serial@vger.kernel.org, andriy.shevchenko@linux.intel.com, peter@hurleysoftware.com, gregkh@linuxfoundation.org, linux-bluetooth@vger.kernel.org, marcel@holtmann.org Subject: Re: [PATCH v3] Revert "serial: 8250_dma: don't bother DMA with small transfers" Message-ID: <20151013112249.GF31893@kuha.fi.intel.com> References: <1444403696-9223-1-git-send-email-frederic.danis@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1444403696-9223-1-git-send-email-frederic.danis@linux.intel.com> List-ID: On Fri, Oct 09, 2015 at 05:14:56PM +0200, Frederic Danis wrote: > This reverts commit 9119fba0cfeda6d415c9f068df66838a104b87cb. > > This commit prevents from sending "big" file using Bluetooth. > When sending a lot of data quickly through the Bluetooth interface, and > after a variable amount of data sent, transfer fails with error: > kernel: [ 415.247453] Bluetooth: hci0 hardware error 0x00 > > Found on T100TA. > > After reverting this commit, send works fine for any file size. > > Signed-off-by: Frederic Danis > Fixes: 9119fba0cfed (serial: 8250_dma: don't bother DMA with small > transfers) > Cc: stable@vger.kernel.org FWIW: Reviewed-by: Heikki Krogerus > --- > v3: Add Fixes and Cc tags > v2: Re-send to correct people > > drivers/tty/serial/8250/8250_dma.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c > index b503071..78259d3 100644 > --- a/drivers/tty/serial/8250/8250_dma.c > +++ b/drivers/tty/serial/8250/8250_dma.c > @@ -77,10 +77,6 @@ int serial8250_tx_dma(struct uart_8250_port *p) > return 0; > > dma->tx_size = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE); > - if (dma->tx_size < p->port.fifosize) { > - ret = -EINVAL; > - goto err; > - } > > desc = dmaengine_prep_slave_single(dma->txchan, > dma->tx_addr + xmit->tail, > -- > 1.9.1 -- heikki