Return-Path: From: Stefan Schmidt Subject: Re: [PATCH bluetooth-next 4/4] 6lowpan: add nhc module for GHC ICMPv6 detection To: Alexander Aring References: <1442577168-23183-1-git-send-email-stefan@osg.samsung.com> <1442577168-23183-5-git-send-email-stefan@osg.samsung.com> <20150918215059.GC6872@omega> Cc: linux-wpan@vger.kernel.org, jukka.rissanen@linux.intel.com, linux-bluetooth@vger.kernel.org Message-ID: <5655BCA9.3090609@osg.samsung.com> Date: Wed, 25 Nov 2015 14:50:33 +0100 MIME-Version: 1.0 In-Reply-To: <20150918215059.GC6872@omega> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wpan-owner@vger.kernel.org List-ID: Hello. On 18/09/15 23:51, Alexander Aring wrote: > On Fri, Sep 18, 2015 at 01:52:48PM +0200, Stefan Schmidt wrote: >> Signed-off-by: Stefan Schmidt >> --- >> net/6lowpan/Kconfig | 5 +++++ >> net/6lowpan/Makefile | 1 + >> net/6lowpan/nhc_ghc_icmpv6.c | 27 +++++++++++++++++++++++++++ >> 3 files changed, 33 insertions(+) >> create mode 100644 net/6lowpan/nhc_ghc_icmpv6.c >> >> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig >> index 67a786b..a34693d 100644 >> --- a/net/6lowpan/Kconfig >> +++ b/net/6lowpan/Kconfig >> @@ -69,4 +69,9 @@ config 6LOWPAN_GHC_UDP >> default y >> ---help--- >> >> +config 6LOWPAN_GHC_ICMPV6 >> + tristate "GHC ICMPv6 Support" >> + default y >> + ---help--- >> + >> endif >> diff --git a/net/6lowpan/Makefile b/net/6lowpan/Makefile >> index fc65efb..49256b7f 100644 >> --- a/net/6lowpan/Makefile >> +++ b/net/6lowpan/Makefile >> @@ -14,3 +14,4 @@ obj-$(CONFIG_6LOWPAN_NHC_UDP) += nhc_udp.o >> #rfc7400 ghcs >> obj-$(CONFIG_6LOWPAN_GHC_EXTENSION_HEADER) += nhc_ghc_extension_header.o >> obj-$(CONFIG_6LOWPAN_GHC_UDP) += nhc_ghc_udp.o >> +obj-$(CONFIG_6LOWPAN_GHC_ICMPV6) += nhc_ghc_icmpv6.o >> diff --git a/net/6lowpan/nhc_ghc_icmpv6.c b/net/6lowpan/nhc_ghc_icmpv6.c >> new file mode 100644 >> index 0000000..378ebfe >> --- /dev/null >> +++ b/net/6lowpan/nhc_ghc_icmpv6.c >> @@ -0,0 +1,27 @@ >> +/* >> + * 6LoWPAN ICMPv6 compression according to RFC7400 >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * as published by the Free Software Foundation; either version >> + * 2 of the License, or (at your option) any later version. >> + */ >> + >> +#include "nhc.h" >> + >> +#define LOWPAN_GHC_ICMPV6_IDLEN 1 >> +#define LOWPAN_GHC_ICMPV6_ID_0 0xdf >> +#define LOWPAN_GHC_ICMPV6_MASK_0 0xff >> + >> +static void icmpv6_ghid_setup(struct lowpan_nhc *nhc) >> +{ >> + nhc->id[0] = LOWPAN_GHC_ICMPV6_ID_0; >> + nhc->idmask[0] = LOWPAN_GHC_ICMPV6_MASK_0; >> +} >> + >> +LOWPAN_NHC(ghc_icmpv6, "RFC7400 ICMPv6", NEXTHDR_HOP, 0, > s/NEXTHDR_HOP/NEXTHDR_ICMP/ Fixed in the new patchset coming later today. regards Stefan Schmidt