Return-Path: <linux-wpan-owner@vger.kernel.org>
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: [PATCH v5] ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154
From: Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <1449829035-9784-1-git-send-email-michael.hennerich@analog.com>
Date: Fri, 11 Dec 2015 00:28:55 -1000
Cc: Alexander Aring <alex.aring@gmail.com>, stefan@datenfreihafen.org,
	linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org
Message-Id: <6284B877-4413-4E6D-AD3F-56BB7E4812D8@holtmann.org>
References: <1449829035-9784-1-git-send-email-michael.hennerich@analog.com>
To: michael.hennerich@analog.com
Sender: linux-wpan-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Michael,

> This driver has been sitting in the linux-zigbee[2] repository for a long
> time. We updated it from time to time and made it available via our
> github kernel repository. The Linux MAC802.15.4 support has improved a lot
> since then. Thanks to all! So it’s finally time to upstream this driver.
> 
> The ADF7242 requires an add-on firmware for the automatic IEEE 802.15.4
> operating modes. The firmware file is currently made available on the
> ADF7242 wiki page here [1]
> 
> [1] http://wiki.analog.com/resources/tools-software/linux-drivers/networking-mac802154/adf7242
> [2] http://sourceforge.net/p/linux-zigbee/kernel/ci/devel/tree/drivers/ieee802154/adf7242.c
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
> 
> ---
> 
> Changes since v4:
> 	-Fix compiler warning
> 	-Reduce xmit timeout to 100ms
> 
> Changes since v3:
> 	-Avoid race condition between xmit and the IRQ handler.
> 	 If we receive a packet while we prepare a transmission we
> 	 must not return to CMD_RX. Introduce atomic bitops flags,
> 	 and drop packets if necessary.
> 	-Refactor IRQ handling logic accordingly.
> 	-Disable CSMA_CA status reported for now.
> 	-For debug purposes adf7242_wait_status() pass line number to called function.
> 	-Use atomic bitops in start/stop.
> 	-Decrease xmit timeout to 250ms.
> 	-Fix error handling path in adf7242_rx().
> 	-Adf7242_isr() factor out debug code into separate function.
> 	-Avoid surplus ifdef DEBUG
> 
> Changes since v2:
> 	-Removed unused variable.
> 	-Removed dead code.
> 
> Changes since v1:
> 	-Add link to the product page/datasheet.
> 	-Add missing includes.
> 	-Use defines for magic PA bias values.
> 	-Unify wait_ready and wait_status functions.
> 	-Add RC_BUSY error handling using soft reset.
> 	 Requires some extra cached parameters.
> 	-Enable adf7242_verify_firmware() only during DEBUG.
> 	-Fixed some compiler warnings.
> 	-Removed sysfs status attribute.
> 	-Added debugfs status file.
> 	-Enable/Disable IRQ in start/stop.
> 	-Added missing MAINTAINER entry.
> 	-Added missing Kconfig help text.
> ---
> .../devicetree/bindings/net/ieee802154/adf7242.txt |   18 +
> MAINTAINERS                                        |    9 +
> drivers/net/ieee802154/Kconfig                     |   11 +
> drivers/net/ieee802154/Makefile                    |    1 +
> drivers/net/ieee802154/adf7242.c                   | 1285 ++++++++++++++++++++
> 5 files changed, 1324 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/ieee802154/adf7242.txt
> create mode 100644 drivers/net/ieee802154/adf7242.c

patch has been applied to bluetooth-next tree.

Regards

Marcel