Return-Path: <joe@perches.com>
Message-ID: <1455556178.4046.14.camel@perches.com>
Subject: Re: [PATCH] Bluetooth: hci_uart: fix boolreturn.cocci warnings
From: Joe Perches <joe@perches.com>
To: kbuild test robot <lkp@intel.com>, Amitkumar Karwar <akarwar@marvell.com>
Cc: kbuild-all@01.org, linux-bluetooth@vger.kernel.org, Nishant Sarmukadam
 <nishants@marvell.com>, linux-kernel@vger.kernel.org, Cathy Luo
 <cluo@marvell.com>,  marcel@holtmann.org, Ganapathi Bhat <gbhat@marvell.com>
Date: Mon, 15 Feb 2016 09:09:38 -0800
In-Reply-To: <20160215162557.GA65463@lkp-hsx03>
References: <201602160006.xiXzASZ0%fengguang.wu@intel.com>
	 <20160215162557.GA65463@lkp-hsx03>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
List-ID: <linux-bluetooth.vger.kernel.org>

On Tue, 2016-02-16 at 00:25 +0800, kbuild test robot wrote:
> drivers/bluetooth/hci_mrvl.c:411:9-10: WARNING: return of 0/1 in
> function 'mrvl_fw_loaded' with return type bool
> 
> ?Return statements in functions returning bool should use
> ?true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> CC: Ganapathi Bhat <gbhat@marvell.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
> ?hci_mrvl.c |????4 ++--
> ?1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/bluetooth/hci_mrvl.c
> +++ b/drivers/bluetooth/hci_mrvl.c
> @@ -408,9 +408,9 @@ static bool mrvl_fw_loaded(struct hci_ua
> ?	struct fw_data *fw_data = mrvl->fwdata;
> ?
> ?	if ((get_cts(hu->tty)) || (fw_data->fw_loaded))
> -		return 1;
> +		return true;
> ?	else
> -		return 0;
> +		return false;
> ?}

Nicer might be

	return get_cts(hu->tty) || fw_data->fw_loaded;
?
> ?/* Set the baud rate */