Return-Path: <stefan@osg.samsung.com>
From: Stefan Schmidt <stefan@osg.samsung.com>
Subject: Re: [RFC 11/12] 6lowpan: add support for getting short address
To: Alexander Aring <aar@pengutronix.de>, linux-wpan@vger.kernel.org
References: <1464031328-17524-1-git-send-email-aar@pengutronix.de>
 <1464031328-17524-12-git-send-email-aar@pengutronix.de>
Cc: kernel@pengutronix.de, marcel@holtmann.org,
 jukka.rissanen@linux.intel.com, hannes@stressinduktion.org,
 mcr@sandelman.ca, werner@almesberger.net, linux-bluetooth@vger.kernel.org,
 netdev@vger.kernel.org
Message-ID: <57481BEB.6050105@osg.samsung.com>
Date: Fri, 27 May 2016 12:05:31 +0200
MIME-Version: 1.0
In-Reply-To: <1464031328-17524-12-git-send-email-aar@pengutronix.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
List-ID: <linux-bluetooth.vger.kernel.org>

Hello.

On 23/05/16 21:22, Alexander Aring wrote:
> In case of sending RA messages we need some way to get the short address
> from an 802.15.4 6LoWPAN interface. This patch will add a temporary
> debugfs entry for experimental userspace api.
>
> Signed-off-by: Alexander Aring<aar@pengutronix.de>
> ---
>   net/6lowpan/debugfs.c | 35 +++++++++++++++++++++++++++++++++++
>   1 file changed, 35 insertions(+)
>
> diff --git a/net/6lowpan/debugfs.c b/net/6lowpan/debugfs.c
> index acbaa3d..638ae59 100644
> --- a/net/6lowpan/debugfs.c
> +++ b/net/6lowpan/debugfs.c
> @@ -245,6 +245,37 @@ static const struct file_operations lowpan_context_fops = {
>   	.release	= single_release,
>   };
>   
> +static int lowpan_short_addr_get(void *data, u64 *val)
> +{
> +	struct wpan_dev *wdev = data;
> +
> +	rtnl_lock();
> +	*val = le16_to_cpu(wdev->short_addr);
> +	rtnl_unlock();
> +
> +	return 0;
> +}
> +
> +DEFINE_SIMPLE_ATTRIBUTE(lowpan_short_addr_fops, lowpan_short_addr_get,
> +			NULL, "0x%04llx\n");
> +
> +static int lowpan_dev_debugfs_802154_init(const struct net_device *dev,
> +					  struct lowpan_dev *ldev)
> +{
> +	struct dentry *dentry;
> +
> +	if (!lowpan_is_ll(dev, LOWPAN_LLTYPE_IEEE802154))
> +		return 0;
> +
> +	dentry = debugfs_create_file("short_addr", 0444, ldev->iface_debugfs,
> +				     lowpan_802154_dev(dev)->wdev->ieee802154_ptr,
> +				     &lowpan_short_addr_fops);
> +	if (!dentry)
> +		return -EINVAL;
> +
> +	return 0;
> +}
> +
>   int lowpan_dev_debugfs_init(struct net_device *dev)
>   {
>   	struct lowpan_dev *ldev = lowpan_dev(dev);
> @@ -272,6 +303,10 @@ int lowpan_dev_debugfs_init(struct net_device *dev)
>   			goto remove_root;
>   	}
>   
> +	ret = lowpan_dev_debugfs_802154_init(dev, ldev);
> +	if (ret < 0)
> +		goto remove_root;
> +
>   	return 0;
>   
>   remove_root:

Reviewed-by: Stefan Schmidt<stefan@osg.samsung.com>

regards
Stefan Schmidt