Return-Path: Subject: Re: [PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions To: Alexander Aring , linux-wpan@vger.kernel.org References: <1461140382-4784-1-git-send-email-aar@pengutronix.de> <1461140382-4784-9-git-send-email-aar@pengutronix.de> Cc: kernel@pengutronix.de, marcel@holtmann.org, jukka.rissanen@linux.intel.com, stefan@osg.samsung.com, mcr@sandelman.ca, werner@almesberger.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy From: Hannes Frederic Sowa Message-ID: Date: Mon, 2 May 2016 21:39:08 +0200 MIME-Version: 1.0 In-Reply-To: <1461140382-4784-9-git-send-email-aar@pengutronix.de> Content-Type: text/plain; charset=utf-8 List-ID: On 20.04.2016 10:19, Alexander Aring wrote: > This patch exports some neighbour discovery functions which can be used > by 6lowpan neighbour discovery ops functionality then. > > Cc: David S. Miller > Cc: Alexey Kuznetsov > Cc: James Morris > Cc: Hideaki YOSHIFUJI > Cc: Patrick McHardy > Signed-off-by: Alexander Aring > --- > include/net/ndisc.h | 16 ++++++++++++++++ > net/ipv6/addrconf.c | 1 + > net/ipv6/ndisc.c | 28 ++++++++++------------------ > 3 files changed, 27 insertions(+), 18 deletions(-) > > diff --git a/include/net/ndisc.h b/include/net/ndisc.h > index 14ed016..35a4396 100644 > --- a/include/net/ndisc.h > +++ b/include/net/ndisc.h > @@ -53,6 +53,15 @@ enum { > > #include > > +/* Set to 3 to get tracing... */ > +#define ND_DEBUG 1 > + > +#define ND_PRINTK(val, level, fmt, ...) \ > +do { \ > + if (val <= ND_DEBUG) \ > + net_##level##_ratelimited(fmt, ##__VA_ARGS__); \ > +} while (0) > + If the debug messages are well thought out, I think we could install them always on debug level. There are valid users now, so Acked-by: Hannes Frederic Sowa