Return-Path: Date: Mon, 20 Jun 2016 13:20:52 -0700 From: Tedd Ho-Jeong An To: Marcel Holtmann Cc: "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH] Bluetooth: Add support for Intel Bluetooth device 3168 [8087:0aa7] Message-ID: <20160620132052.118f8ee6@fedora-linux-22.shared> In-Reply-To: <8FDD3771-6106-4F35-9783-9D41D357BAB8@holtmann.org> References: <20160620120550.199d2e8f@fedora-linux-22.shared> <8FDD3771-6106-4F35-9783-9D41D357BAB8@holtmann.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-ID: Hi Marcel On Mon, 20 Jun 2016 22:12:23 +0200 Marcel Holtmann wrote: > Hi Tedd, > > > This patch adds support for Intel Bluetooth device 3168 also known > > as Sandy Peak (SdP). > > > > T: Bus=01 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 4 Spd=12 MxCh= 0 > > D: Ver= 2.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > > P: Vendor=8087 ProdID=0aa7 Rev= 0.01 > > C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA > > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=1ms > > E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms > > E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms > > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms > > I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms > > I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms > > I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms > > I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms > > I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb > > E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms > > E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms > > > > Signed-off-by: Tedd Ho-Jeong An > > --- > > drivers/bluetooth/btusb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > > index a3be65e..9a2c602 100644 > > --- a/drivers/bluetooth/btusb.c > > +++ b/drivers/bluetooth/btusb.c > > @@ -313,6 +313,7 @@ static const struct usb_device_id blacklist_table[] = { > > { USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR }, > > { USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL }, > > { USB_DEVICE(0x8087, 0x0a2a), .driver_info = BTUSB_INTEL }, > > + { USB_DEVICE(0x8087, 0x0aa7), .driver_info = BTUSB_INTEL }, > > { USB_DEVICE(0x8087, 0x0a2b), .driver_info = BTUSB_INTEL_NEW }, > > so SdP is actually iBT 2.x based? Yes, actually, SdP is WiFi 1x1 module and BT is same as StP D1. It just magically has a different VID/PID. > > Even while this looks odd, lets keep the list sorted by PID and not by driver_info. ACK, I will send out new one shortly. > > Regards > > Marcel >