Return-Path: From: Stefan Schmidt Subject: Re: [PATCHv3 net-next 04/12] ndisc: add __ndisc_opt_addr_space function To: Alexander Aring , linux-wpan@vger.kernel.org References: <20160614115239.17788-1-aar@pengutronix.de> <20160614115239.17788-5-aar@pengutronix.de> Cc: kernel@pengutronix.de, marcel@holtmann.org, jukka.rissanen@linux.intel.com, hannes@stressinduktion.org, mcr@sandelman.ca, werner@almesberger.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy Message-ID: <57616FAD.9080106@osg.samsung.com> Date: Wed, 15 Jun 2016 17:09:33 +0200 MIME-Version: 1.0 In-Reply-To: <20160614115239.17788-5-aar@pengutronix.de> Content-Type: text/plain; charset=windows-1252; format=flowed List-ID: Hello. On 14/06/16 13:52, Alexander Aring wrote: > This patch adds __ndisc_opt_addr_space as low-level function for > ndisc_opt_addr_space which doesn't depend on net_device parameter. > > Cc: David S. Miller > Cc: Alexey Kuznetsov > Cc: James Morris > Cc: Hideaki YOSHIFUJI > Cc: Patrick McHardy > Signed-off-by: Alexander Aring > --- > include/net/ndisc.h | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/net/ndisc.h b/include/net/ndisc.h > index 2d8edaa..4cee826 100644 > --- a/include/net/ndisc.h > +++ b/include/net/ndisc.h > @@ -127,10 +127,15 @@ static inline int ndisc_addr_option_pad(unsigned short type) > } > } > > +static inline int __ndisc_opt_addr_space(unsigned char addr_len, int pad) > +{ > + return NDISC_OPT_SPACE(addr_len + pad); > +} > + > static inline int ndisc_opt_addr_space(struct net_device *dev) > { > - return NDISC_OPT_SPACE(dev->addr_len + > - ndisc_addr_option_pad(dev->type)); > + return __ndisc_opt_addr_space(dev->addr_len, > + ndisc_addr_option_pad(dev->type)); > } > > static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p, Reviewed-by: Stefan Schmidt regards Stefan Schmidt