Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1471419377-9522-1-git-send-email-michal.narajowski@codecoup.pl> <88A4E00C-20B0-47D6-A22A-16D632CE24F5@holtmann.org> From: =?UTF-8?Q?Micha=C5=82_Narajowski?= Date: Wed, 17 Aug 2016 10:05:15 +0200 Message-ID: Subject: Re: [PATCH BlueZ v3] client: Add better support for managing devices of multiple controllers To: =?UTF-8?Q?Micha=C5=82_Narajowski?= Cc: Marcel Holtmann , linux-bluetooth@vger.kernel.org Content-Type: multipart/alternative; boundary=001a1133288cf3c10d053a3fecfc List-ID: --001a1133288cf3c10d053a3fecfc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Added mailing list in CC. 2016-08-17 9:55 GMT+02:00 Micha=C5=82 Narajowski : > Hi Marcel, > > of course I should have used libshared-glib.la. Will fix that. I needed > it for new0() by the way. > > Regards, > Micha=C5=82 Narajowski > > 2016-08-17 9:45 GMT+02:00 Marcel Holtmann : > >> Hi Michal, >> >> > Previously devices list was cleared when selecting new default >> > controller. Now devices list is preserverd allowing to list and sugges= t >> > devices for default controller even after changing the default >> > controller. >> > --- >> > Makefile.tools | 2 +- >> > client/main.c | 262 ++++++++++++++++++++++++++++++ >> +++++++++++---------------- >> > 2 files changed, 189 insertions(+), 75 deletions(-) >> > >> > diff --git a/Makefile.tools b/Makefile.tools >> > index 7706dc7..944c8e9 100644 >> > --- a/Makefile.tools >> > +++ b/Makefile.tools >> > @@ -10,7 +10,7 @@ client_bluetoothctl_SOURCES =3D client/main.c \ >> > client/gatt.h client/gatt.c \ >> > monitor/uuid.h monitor/uuid.c >> > client_bluetoothctl_LDADD =3D gdbus/libgdbus-internal.la @GLIB_LIBS@ >> @DBUS_LIBS@ \ >> > - -lreadline >> > + -lreadline src/libshared-mainloop.la >> >> I have no idea on how this is going to work. It would need to be >> libshared-glib.la first of all, and second of all, what would you be >> using in a D-Bus client that justifies using it. >> >> Regards >> >> Marcel >> >> > --001a1133288cf3c10d053a3fecfc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Added mailing = list in CC.

2016-08-17 9:55 GMT+= 02:00 Micha=C5=82 Narajowski <michal.narajowski@codecoup.pl>:

Hi Marcel,=

of course I should have used libshared-glib.la. Will fix that. I needed= it for new0() by the way.

Regards,
Mich= a=C5=82 Narajowski

2016-08-17 9:45 GMT+02= :00 Marcel Holtmann <marcel@holtmann.org>:
Hi Michal,

> Previously devices list was cleared when selecting new default
> controller. Now devices list is preserverd allowing to list and sugges= t
> devices for default controller even after changing the default
> controller.
> ---
> Makefile.tools |=C2=A0 =C2=A02 +-
> client/main.c=C2=A0 | 262 +++++++++++++++++++++++++++++++++++++++= ++----------------
> 2 files changed, 189 insertions(+), 75 deletions(-)
>
> diff --git a/Makefile.tools b/Makefile.tools
> index 7706dc7..944c8e9 100644
> --- a/Makefile.tools
> +++ b/Makefile.tools
> @@ -10,7 +10,7 @@ client_bluetoothctl_SOURCES =3D client/main.c \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0client= /gatt.h client/gatt.c \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0monito= r/uuid.h monitor/uuid.c
> client_bluetoothctl_LDADD =3D gdbus/libgdbus-internal.la @GLIB_L= IBS@ @DBUS_LIBS@ \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-lreadline
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-lreadline src/libshared-mainloop.la<= /a>

I have no idea on how this is going to work. It would need to be libs= hared-glib.la first of all, and second of all, what would you be using = in a D-Bus client that justifies using it.

Regards

Marcel

--001a1133288cf3c10d053a3fecfc--