Return-Path: Date: Fri, 31 Mar 2017 16:15:47 +0200 From: Konrad Zapalowicz To: "Von Dentz, Luiz" Cc: Bastien Nocera , Marcel Holtmann , "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH] core: replace sizeof(filename) with PATH_MAX Message-ID: <20170331141547.GB28779@annapurna> References: <1490958237-9299-1-git-send-email-bergo.torino@gmail.com> <1490959289.13868.12.camel@hadess.net> <20170331113218.GA28779@annapurna> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: List-ID: On 03/31, Von Dentz, Luiz wrote: > Hi Konrad, > > On Fri, Mar 31, 2017 at 2:32 PM, Konrad Zapalowicz > wrote: > > On 03/31, Bastien Nocera wrote: > >> On Fri, 2017-03-31 at 13:03 +0200, Konrad Zapalowicz wrote: > >> > From: Konrad ZapaƂowicz > >> > > >> > This commit replaces sizeof(filename) with PATH_MAX to match the > >> > common > >> > scheme which is used in other places. > >> > >> I wonder why g_strdup_printf() isn't used instead. Would allow ignoring > >> PATH_MAX. > > > > I guess it is because it is easier. With g_strdup_printf() one would > > have to take care about freeing memory. This is not a case with having > > filename as an atomatic variable. > > Patch looks fine, but we don't use Signed-off-by in userspace tree Ok, will resend. Thanks, K