Return-Path: MIME-Version: 1.0 In-Reply-To: References: <20170920074417.30435-1-luiz.dentz@gmail.com> From: Luiz Augusto von Dentz Date: Fri, 22 Sep 2017 13:58:44 +0300 Message-ID: Subject: Re: [PATCH v2 00/10] gatt: Add server support for AcquireWrite and AcquireNotify To: Yunhan Wang Cc: "linux-bluetooth@vger.kernel.org" , Jonah Petri Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Thu, Sep 21, 2017 at 9:15 PM, Yunhan Wang wrote: > Hi, Luiz > > It is pretty good. > > Thanks > Best wishes > Yunhan > > On Thu, Sep 21, 2017 at 12:49 AM, Luiz Augusto von Dentz > wrote: >> Hi, >> >> On Wed, Sep 20, 2017 at 10:44 AM, Luiz Augusto von Dentz >> wrote: >>> From: Luiz Augusto von Dentz >>> >>> This implements similar mechanist to use dedicated file descriptors >>> for IO bypassing D-Bus. >>> >>> Note: The current implementation opens just one fd per characteristic, >>> though it could be possible to have one fd per device. >>> >>> v2: Allow any type of write procedure to work when WriteAcquired exists. >>> >>> Luiz Augusto von Dentz (10): >>> gatt: Remove useless debug >>> client: Rework variables for AcquireWrite/AcquireNotify >>> doc/gatt-api: Add server support for AcquireWrite and AcquireNotify >>> shared/gatt-server: Add bt_gatt_server_get_mtu >>> shared/gatt-db: Add gatt_db_attribute_get_user_data >>> gatt: Implement AcquireWrite for server >>> client: Implement AcquireWrite for server >>> gatt: Implement AcquireNotify for server >>> client: Implement AcquireNotify for server >>> gatt: Update signature of AcquireWrite and AcquireNotify >>> >>> client/gatt.c | 319 ++++++++++++++++++++++++++++++++++++++++------- >>> doc/gatt-api.txt | 36 ++++-- >>> mesh/gatt.c | 23 +++- >>> src/gatt-client.c | 8 +- >>> src/gatt-database.c | 258 +++++++++++++++++++++++++++++++++++++- >>> src/shared/gatt-db.c | 8 ++ >>> src/shared/gatt-db.h | 2 + >>> src/shared/gatt-server.c | 8 ++ >>> src/shared/gatt-server.h | 1 + >>> 9 files changed, 598 insertions(+), 65 deletions(-) >>> >>> -- >>> 2.13.5 >> >> Any other feedback on this? Does it address all the use cases you guys >> have been struggling? Applied. -- Luiz Augusto von Dentz