Return-Path: MIME-Version: 1.0 In-Reply-To: References: <20170823225839.461-1-yunhanw@google.com> From: Yunhan Wang Date: Tue, 19 Sep 2017 22:55:30 -0700 Message-ID: Subject: Re: [PATCH BlueZ] build: use abspath for lib/bluetooth To: Marcel Holtmann Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset="UTF-8" List-ID: Hi, Marcel Any other concern on this patch? Thanks Best wishes Yunhan On Mon, Sep 18, 2017 at 9:47 PM, Yunhan Wang wrote: > Hi, Marcel > > I just run make distcheck, it is working with this change upon latest mas= ter. > > Could you help to apply it? > > The below are detailed step. > 1. ./configure --prefix=3D/usr --mandir=3D/usr/share/man --sysconfdir=3D/= etc > --localstatedir=3D/var --enable-experimental > --with-systemdsystemunitdir=3D/lib/systemd/system > --with-systemduserunitdir=3D/usr/lib/systemd --enable-deprecated > --enable-tools --enable-testing --enable-experimental > 2. make distcheck > > Thanks > Best wishes > Yunhan > > On Mon, Aug 28, 2017 at 10:08 PM, Marcel Holtmann w= rote: >> Hi Yunhan, >> >>> When building from out of tree, and the top build dir was specified as >>> an absolute path, the linked headers in ${builddir}/lib/bluetooth were >>> broken. This patch fixes it by relying on make's abspath macro as >>> opposed to the path concatenation. >>> --- >>> Makefile.am | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Makefile.am b/Makefile.am >>> index eaed632e8..ad638cbb2 100644 >>> --- a/Makefile.am >>> +++ b/Makefile.am >>> @@ -499,7 +499,7 @@ $(lib_libbluetooth_la_OBJECTS): $(local_headers) >>> >>> lib/bluetooth/%.h: lib/%.h >>> $(AM_V_at)$(MKDIR_P) lib/bluetooth >>> - $(AM_V_GEN)$(LN_S) -f "$(abs_top_builddir)"/$< $@ >>> + $(AM_V_GEN)$(LN_S) -f $(abspath $<) $@ >> >> does =E2=80=9Cfakeroot make distcheck=E2=80=9D still works when doing th= is change? >> >> Regards >> >> Marcel >>