Return-Path: <linux-bluetooth-owner@vger.kernel.org>
MIME-Version: 1.0
In-Reply-To: <CAFxSrVu-vApomoiJzr1CL-_qgdMUcmKWbx1-QdupMY2-ACE4xw@mail.gmail.com>
References: <20170908221934.11910-1-inga.stotland@intel.com> <CAFxSrVu-vApomoiJzr1CL-_qgdMUcmKWbx1-QdupMY2-ACE4xw@mail.gmail.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Mon, 11 Sep 2017 16:10:43 +0300
Message-ID: <CABBYNZKkJEHgD4nPu46GXaNXum_KYZnbLJxA6A+B6_7CJpbvYA@mail.gmail.com>
Subject: Re: [PATCH BlueZ] mesh: Add characteristic property name check
To: Laczen JMS <laczenjms@gmail.com>
Cc: Inga Stotland <inga.stotland@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi,

On Sat, Sep 9, 2017 at 12:07 PM, Laczen JMS <laczenjms@gmail.com> wrote:
> Hi Inga,
>
> This solves the issue.
>
> Kind regards,
>
> Jehudi
>
> 2017-09-09 0:19 GMT+02:00 Inga Stotland <inga.stotland@intel.com>:
>> If PropertyChanged signal is not emitted due to a change in
>> characteristic's "Value" property, the characteristic does
>> not need to be processed.
>> ---
>>  mesh/main.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/mesh/main.c b/mesh/main.c
>> index 42506a6..3a39d8f 100644
>> --- a/mesh/main.c
>> +++ b/mesh/main.c
>> @@ -1295,8 +1295,9 @@ static void property_changed(GDBusProxy *proxy, const char *name,
>>                 rl_printf("Characteristic property changed %s\n",
>>                                                 g_dbus_proxy_get_path(proxy));
>>
>> -               if ((connection.type == CONN_TYPE_PROVISION) ||
>> -                                                       connection.session_open)
>> +               if ((strcmp(name, "Value") == 0) &&
>> +                               ((connection.type == CONN_TYPE_PROVISION) ||
>> +                                               connection.session_open))
>>                         process_mesh_characteristic(proxy);
>>         }
>>  }
>> --
>> 2.9.5

Applied, thanks.

-- 
Luiz Augusto von Dentz