Return-Path: MIME-Version: 1.0 In-Reply-To: References: From: Luiz Augusto von Dentz Date: Fri, 8 Sep 2017 16:47:55 +0300 Message-ID: Subject: Re: [PATCH 1/1] mesh: Remove StopNotify method to avoid reading data twice on some mesh nodes To: Laczen JMS Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Jehudi, On Fri, Sep 8, 2017 at 3:30 PM, Laczen JMS wrote: > Some mesh nodes do not change (e.g. zephyr) the notification when > given the StopNotify. As a result the data from the notification > channel is processed twice. This patch removes the StopNotify. What do you mean the node do not change? Perhaps this is the result of bluetoothd remembering the subscriptions so you don't have to StopNotify while disconnected, though this should not cause the data to be processed twice otherwise we have a bug somewhere in the daemon. > Kind regards, > > Jehudi > > diff --git a/mesh/gatt.c b/mesh/gatt.c > index f9615b3..7d3b869 100644 > --- a/mesh/gatt.c > +++ b/mesh/gatt.c > @@ -589,15 +589,10 @@ bool mesh_gatt_notify(GDBusProxy *proxy, bool > enable, GDBusReturnFunction cb, > cb = notify_reply; > } > } else { > - if (notify_io) { > - notify_io_destroy(); > - if (cb) > - cb(NULL, user_data); > - return true; > - } else { > - method = "StopNotify"; > - cb = notify_reply; > - } > + if (notify_io) notify_io_destroy(); > + if (cb) cb(NULL, user_data); > + > + return true; > } > > if (g_dbus_proxy_method_call(proxy, method, NULL, cb, > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Luiz Augusto von Dentz