Return-Path: MIME-Version: 1.0 In-Reply-To: <20171003183507.37885-1-yunhanw@google.com> References: <20171003183507.37885-1-yunhanw@google.com> From: Luiz Augusto von Dentz Date: Wed, 4 Oct 2017 14:19:04 +0300 Message-ID: Subject: Re: [PATCH BlueZ] gatt: Fix sending indications with proxy To: Yunhan Wang Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Yunhan, On Tue, Oct 3, 2017 at 9:35 PM, Yunhan Wang wrote: > When using AcquireNotify with indication, the proxy needs to be filled in > send_notification_to_devices so as to get indication confirmation in > applciation. > --- > src/gatt-database.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gatt-database.c b/src/gatt-database.c > index 0c84b2569..47304704a 100644 > --- a/src/gatt-database.c > +++ b/src/gatt-database.c > @@ -1831,7 +1831,7 @@ static bool pipe_io_read(struct io *io, void *user_data) > buf, bytes_read, > gatt_db_attribute_get_handle(chrc->ccc), > chrc->props & BT_GATT_CHRC_PROP_INDICATE, > - NULL); > + chrc->proxy); > > return true; > } > -- > 2.14.2.822.g60be5d43e6-goog Im not sure this the correct fix, the reason why the proxy is NULL is because the fd is being used for io, though the confirmation has no effect on the flow control Id expect some inband signalling in this case but that might actually require something like a socketpair in order to be able to write confirmation back. -- Luiz Augusto von Dentz