Return-Path: Subject: Re: [PATCH 7/9] Bluetooth: hci_bcm: Make acpi_probe get irq from ACPI resources To: Hans de Goede , Marcel Holtmann , Gustavo Padovan , Johan Hedberg Cc: Sebastian Reichel , robh@kernel.org, linux-bluetooth@vger.kernel.org, linux-serial@vger.kernel.org, linux-acpi@vger.kernel.org References: <20171002152356.4714-1-hdegoede@redhat.com> <20171002152356.4714-8-hdegoede@redhat.com> From: =?UTF-8?Q?Fr=c3=a9d=c3=a9ric_Danis?= Message-ID: Date: Tue, 3 Oct 2017 19:21:48 +0200 MIME-Version: 1.0 In-Reply-To: <20171002152356.4714-8-hdegoede@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed List-ID: Hi Hans, First of all, many thanks for your work on this, it helped me a lot to get full Bluetooth on my Asus T100. Le 02/10/2017 à 17:23, Hans de Goede a écrit : > The ACPI subsys is going to move over to instantiating ACPI enumerated > HCIs as serdevs, rather then as platform devices. > > So we need to make bcm_acpi_probe() suitable for use on non platform- > devices too, which means that we cannot rely on platform_get_irq() > getting called. > > This commit modifies bcm_acpi_probe() to directly get the irq from > the ACPI resources, this is a preparation patch for adding (runtime)pm > support to the serdev path. > > Signed-off-by: Hans de Goede > --- > drivers/bluetooth/hci_bcm.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c > index 5c8371d8aace..48a428909958 100644 > --- a/drivers/bluetooth/hci_bcm.c > +++ b/drivers/bluetooth/hci_bcm.c > @@ -805,6 +805,7 @@ static int bcm_acpi_probe(struct bcm_device *dev) > const struct dmi_system_id *dmi_id; > const struct acpi_gpio_mapping *gpio_mapping = acpi_bcm_int_last_gpios; > const struct acpi_device_id *id; > + struct resource_entry *entry; > int ret; > > /* Retrieve GPIO data */ > @@ -821,6 +822,13 @@ static int bcm_acpi_probe(struct bcm_device *dev) > &resources, bcm_resource, dev); > if (ret < 0) > return ret; > + > + resource_list_for_each_entry(entry, &resources) { > + if (resource_type(entry->res) == IORESOURCE_IRQ) { > + dev->irq = entry->res->start; > + break; > + } > + } > acpi_dev_free_resource_list(&resources); > > dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table); You should also return 0 in bcm_resource(), otherwise the resources list is empty, ending up with "BCM irq: -22" trace in dmesg. Regards, Frédéric Danis