Return-Path: MIME-Version: 1.0 In-Reply-To: <4d4ac18f570efc6371bc44c70836bdd3ddee3902.1514916630.git.lukas@wunner.de> References: <4d4ac18f570efc6371bc44c70836bdd3ddee3902.1514916630.git.lukas@wunner.de> From: Linus Walleij Date: Wed, 3 Jan 2018 08:52:51 +0100 Message-ID: Subject: Re: [PATCH v2 01/10] Bluetooth: Depend on rather than select GPIOLIB To: Lukas Wunner Cc: Marcel Holtmann , Johan Hedberg , Mika Westerberg , Andy Shevchenko , Frederic Danis , Loic Poulain , Hans de Goede , Max Shavrick , Leif Liddy , Daniel Roschka , Ronald Tschalaer , "Peter Y. Chuang" , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset="UTF-8" List-ID: On Tue, Jan 2, 2018 at 8:08 PM, Lukas Wunner wrote: > Commit 27378f4c1b92 ("Bluetooth: Avoid WARN splat due to missing > GPIOLIB") amended Kconfig to select GPIOLIB if BT_HCIUART_NOKIA, > BT_HCIUART_INTEL or BT_HCIUART_BCM is enabled since all three drivers > require it to function. > > The diagnosis was correct but the treatment was not. As stated in > Documentation/gpio/consumer.txt: > > Guidelines for GPIOs consumers > ============================== > > Drivers that can't work without standard GPIO calls should have > Kconfig entries that depend on GPIOLIB. > ^^^^^^^^^ > Fix it. > > Reported-by: Andy Shevchenko > Cc: Linus Walleij > Signed-off-by: Lukas Wunner Reviewed-by: Linus Walleij Yours, Linus Walleij