Return-Path: MIME-Version: 1.0 In-Reply-To: <2A1D60F1-F86F-4A2B-A43A-F3419506DE99@holtmann.org> References: <20180101204217.26165-1-martin.blumenstingl@googlemail.com> <20180101204217.26165-3-martin.blumenstingl@googlemail.com> <2A1D60F1-F86F-4A2B-A43A-F3419506DE99@holtmann.org> From: Martin Blumenstingl Date: Tue, 2 Jan 2018 22:10:48 +0100 Message-ID: Subject: Re: [RFC v2 2/9] dt-bindings: net: bluetooth: add support for Realtek Bluetooth chips To: Marcel Holtmann Cc: Rob Herring , devicetree , "open list:BLUETOOTH DRIVERS" , linux-serial@vger.kernel.org, Mark Rutland , "Gustavo F. Padovan" , Johan Hedberg , Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , linux-amlogic@lists.infradead.org, Larry Finger , Carlo Caione , Daniel Drake Content-Type: text/plain; charset="UTF-8" List-ID: Hi Marcel, On Tue, Jan 2, 2018 at 12:16 PM, Marcel Holtmann wrote: > Hi Martin, > >> This adds the documentation for Bluetooth functionality of the Realtek >> RTL8723BS and RTL8723DS. >> Both are SDIO wifi chips with an additional Bluetooth module which is >> connected via UART to the host. >> >> Signed-off-by: Martin Blumenstingl >> --- >> .../devicetree/bindings/net/realtek-bluetooth.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.txt >> >> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.txt b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt >> new file mode 100644 >> index 000000000000..1491329c4cd1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.txt >> @@ -0,0 +1,41 @@ >> +Realtek Bluetooth Chips >> +----------------------- >> + >> +This documents the binding structure and common properties for serial >> +attached Realtek devices. >> + >> +Serial attached Realtek devices shall be a child node of the host UART >> +device the slave device is attached to. See ../serial/slave-device.txt >> +for more information >> + >> +Required properties: >> +- compatible: should contain one of the following: >> + * "realtek,rtl8723bs-bluetooth" >> + * "realtek,rtl8723ds-bluetooth" >> + >> +Optional properties: >> +- realtek,config-data: Bluetooth chipset configuration data which is >> + needed for communication (it typically contains >> + board specific settings like the baudrate and >> + whether flow-control is used). >> + This is an array of u8 values. > > any chance we can at least include the basic format of these config blobs. And I prefer at least an ACK from Rob here. with including the basic format you mean a description that the config blob should start with 0x55 0xab 0x23 0x87 (which translates to: 0x8723ab55)? I think all non-trivial dt-binding patches should be ACKed by the DT maintainers, so waiting for Rob's ACK is perfectly fine for me >> +- enable-gpios: GPIO specifier, used to enable/disable the BT module >> +- reset-gpios: GPIO specifier, used to reset the BT module >> + >> + >> +Example: >> + >> +&uart { >> + ... >> + >> + bluetooth { >> + compatible = "realtek,rtl8723bs-bluetooth"; >> + enable-gpios = <&gpio 20 GPIO_ACTIVE_HIGH>; >> + reset-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>; >> + realtek,config-data = /bits/ 8 < >> + 0x55 0xab 0x23 0x87 0x29 0x00 0xf4 0x00 0x01 0x01 0xf6 0x00 >> + 0x02 0x81 0x00 0xfa 0x00 0x02 0x12 0x80 0x0c 0x00 0x10 0x02 >> + 0x80 0x92 0x04 0x50 0xc5 0xea 0x19 0xe1 0x1b 0xfd 0xaf 0x5f >> + 0x01 0xa4 0x0b 0xd9 0x00 0x01 0x0f 0xe4 0x00 0x01 0x08>; >> + }; >> +}; Regards Martin