Return-Path: Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version From: Kai-Heng Feng In-Reply-To: <1a08612e-2531-3711-ec0f-a867e86d0009@redhat.com> Date: Sun, 18 Feb 2018 16:13:13 +0800 Cc: Marcel Holtmann , Brian Norris , "Gustavo F. Padovan" , Johan Hedberg , Bluez mailing list , linux-serial@vger.kernel.org, ACPI Devel Maling List , stable , Leif Liddy , Matthias Kaehlcke , Daniel Drake , matadeen@qti.qualcomm.com, Linux Kernel Mailing List , Greg Kroah-Hartman , Guenter Roeck Message-Id: References: <20180108094416.4789-1-hdegoede@redhat.com> <20180213022455.GA151190@rodete-desktop-imager.corp.google.com> <8cd918fd-bf6f-70ac-e561-e7deffa695f0@redhat.com> <20180216022721.GA69988@rodete-desktop-imager.corp.google.com> <345b0de8-1a23-d2f8-bc56-507eadf7faa7@redhat.com> <6B37F6AC-1103-4FCF-A5DC-4BA236A7B11B@holtmann.org> <1a08612e-2531-3711-ec0f-a867e86d0009@redhat.com> To: Hans de Goede List-ID: > On 16 Feb 2018, at 8:10 PM, Hans de Goede wrote: >=20 >=20 > Ok, I've asked the reporter of: >=20 > https://bugzilla.redhat.com/show_bug.cgi?id=3D1514836 >=20 > Which is how I got involved in this to provide DMI data and > I will whip up a patch for his machine and ask him to test > and once that is done submit upstream. This is the only machine > I'm aware of though and looking at the history of this I think > there will be others. I have one machine needs the quirk. I=E2=80=99ll also send a patch to match its DMI. Kai-Heng >=20 >> I addition we can add a module option to btusb.ko that allows us to = force this flag to be set. That way testing this is easy on a vendor = kernel. A bunch of the btusb quirks (and also core quirks) can be tested = via module options or debugfs. >=20 > Yes a module option for this is a good idea. >=20 > Regards, >=20 > Hans >=20 >=20