Return-Path: From: Grzegorz Kolodziejczyk To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ] client: Add possiblity to define maximum attribute value length Date: Thu, 26 Apr 2018 16:55:20 +0200 Message-Id: <20180426145520.13225-1-grzegorz.kolodziejczyk@codecoup.pl> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: This patch allows to define maximum value length for characteristic and descriptor value while registering. --- client/gatt.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++------------ client/gatt.h | 4 ++++ client/main.c | 13 ++++++------ 3 files changed, 64 insertions(+), 19 deletions(-) diff --git a/client/gatt.c b/client/gatt.c index d59d1ba1e..969a78be0 100644 --- a/client/gatt.c +++ b/client/gatt.c @@ -60,6 +60,7 @@ struct desc { char *uuid; char **flags; int value_len; + unsigned int max_val_len; uint8_t *value; }; @@ -71,6 +72,7 @@ struct chrc { bool notifying; GList *descs; int value_len; + unsigned int max_val_len; uint8_t *value; uint16_t mtu; struct io *write_io; @@ -612,7 +614,7 @@ static void write_attribute(GDBusProxy *proxy, char *val_str, uint16_t offset) { struct iovec iov; struct write_attribute_data wd; - uint8_t value[512]; + uint8_t value[MAX_ATTR_VAL_LEN]; char *entry; unsigned int i; @@ -689,7 +691,7 @@ void gatt_write_attribute(GDBusProxy *proxy, int argc, char *argv[]) static bool pipe_read(struct io *io, void *user_data) { struct chrc *chrc = user_data; - uint8_t buf[512]; + uint8_t buf[MAX_ATTR_VAL_LEN]; int fd = io_get_fd(io); ssize_t bytes_read; @@ -1611,7 +1613,8 @@ static DBusMessage *chrc_read_value(DBusConnection *conn, DBusMessage *msg, return read_value(msg, &chrc->value[offset], chrc->value_len - offset); } -static int parse_value_arg(DBusMessageIter *iter, uint8_t **value, int *len) +static int parse_value_arg(DBusMessageIter *iter, uint8_t **value, int *len, + int max_len) { DBusMessageIter array; uint16_t offset = 0; @@ -1628,6 +1631,9 @@ static int parse_value_arg(DBusMessageIter *iter, uint8_t **value, int *len) if (parse_options(iter, &offset, NULL, NULL, NULL)) return -EINVAL; + if ((offset + read_len) > max_len) + return -EOVERFLOW; + if ((offset + read_len) > *len) { *len = offset + read_len; *value = g_realloc(*value, *len); @@ -1645,6 +1651,7 @@ static void authorize_write_response(const char *input, void *user_data) DBusMessageIter iter; DBusMessage *reply; char *err; + int errsv; dbus_message_iter_init(pending_message, &iter); @@ -1656,10 +1663,16 @@ static void authorize_write_response(const char *input, void *user_data) chrc->authorized = true; - if (parse_value_arg(&iter, &chrc->value, &chrc->value_len)) { + errsv = parse_value_arg(&iter, &chrc->value, &chrc->value_len, + chrc->max_val_len); + if (errsv == -EINVAL) { err = "org.bluez.Error.InvalidArguments"; goto error; + } else if (errsv == -EOVERFLOW) { + err = "org.bluez.Error.InvalidValueLength"; + + goto error; } bt_shell_printf("[" COLORED_CHG "] Attribute %s written" , chrc->path); @@ -1685,6 +1698,7 @@ static DBusMessage *chrc_write_value(DBusConnection *conn, DBusMessage *msg, struct chrc *chrc = user_data; DBusMessageIter iter; char *str; + int errsv; dbus_message_iter_init(msg, &iter); @@ -1706,10 +1720,15 @@ static DBusMessage *chrc_write_value(DBusConnection *conn, DBusMessage *msg, return NULL; } - if (parse_value_arg(&iter, &chrc->value, &chrc->value_len)) + errsv = parse_value_arg(&iter, &chrc->value, &chrc->value_len, + chrc->max_val_len); + if (errsv == -EINVAL) { return g_dbus_create_error(msg, - "org.bluez.Error.InvalidArguments", - NULL); + "org.bluez.Error.InvalidArguments", NULL); + } else if (errsv == -EOVERFLOW) { + return g_dbus_create_error(msg, + "org.bluez.Error.InvalidValueLength", NULL); + } bt_shell_printf("[" COLORED_CHG "] Attribute %s written" , chrc->path); @@ -1881,9 +1900,9 @@ static const GDBusMethodTable chrc_methods[] = { { } }; -static uint8_t *str2bytearray(char *arg, int *val_len) +static uint8_t *str2bytearray(char *arg, int *val_len, unsigned int max_val_len) { - uint8_t value[512]; + uint8_t value[MAX_ATTR_VAL_LEN]; char *entry; unsigned int i; @@ -1908,6 +1927,12 @@ static uint8_t *str2bytearray(char *arg, int *val_len) value[i] = val; } + if (i > max_val_len) { + bt_shell_printf("Value exceeds maximum length (%i)\n", + max_val_len); + return NULL; + } + *val_len = i; return g_memdup(value, i); @@ -1919,7 +1944,13 @@ static void chrc_set_value(const char *input, void *user_data) g_free(chrc->value); - chrc->value = str2bytearray((char *) input, &chrc->value_len); + chrc->value = str2bytearray((char *) input, &chrc->value_len, + chrc->max_val_len); + + if (!chrc->value) { + print_chrc(chrc, COLORED_DEL); + chrc_unregister(chrc); + } } void gatt_register_chrc(DBusConnection *conn, GDBusProxy *proxy, @@ -1940,7 +1971,8 @@ void gatt_register_chrc(DBusConnection *conn, GDBusProxy *proxy, chrc->uuid = g_strdup(argv[1]); chrc->path = g_strdup_printf("%s/chrc%p", service->path, chrc); chrc->flags = g_strsplit(argv[2], ",", -1); - chrc->authorization_req = argc > 3 ? true : false; + chrc->max_val_len = argc > 3 ? atoi(argv[3]) : MAX_ATTR_VAL_LEN; + chrc->authorization_req = argc > 4 ? true : false; if (g_dbus_register_interface(conn, chrc->path, CHRC_INTERFACE, chrc_methods, NULL, chrc_properties, @@ -2037,7 +2069,8 @@ static DBusMessage *desc_write_value(DBusConnection *conn, DBusMessage *msg, dbus_message_iter_init(msg, &iter); - if (parse_value_arg(&iter, &desc->value, &desc->value_len)) + if (parse_value_arg(&iter, &desc->value, &desc->value_len, + desc->max_val_len)) return g_dbus_create_error(msg, "org.bluez.Error.InvalidArguments", NULL); @@ -2140,7 +2173,13 @@ static void desc_set_value(const char *input, void *user_data) g_free(desc->value); - desc->value = str2bytearray((char *) input, &desc->value_len); + desc->value = str2bytearray((char *) input, &desc->value_len, + desc->max_val_len); + + if (!desc->value) { + print_desc(desc, COLORED_DEL); + desc_unregister(desc); + } } void gatt_register_desc(DBusConnection *conn, GDBusProxy *proxy, @@ -2166,6 +2205,7 @@ void gatt_register_desc(DBusConnection *conn, GDBusProxy *proxy, desc->uuid = g_strdup(argv[1]); desc->path = g_strdup_printf("%s/desc%p", desc->chrc->path, desc); desc->flags = g_strsplit(argv[2], ",", -1); + desc->max_val_len = argc > 3 ? atoi(argv[3]) : MAX_ATTR_VAL_LEN; if (g_dbus_register_interface(conn, desc->path, DESC_INTERFACE, desc_methods, NULL, desc_properties, diff --git a/client/gatt.h b/client/gatt.h index 957ae8003..189a0aa40 100644 --- a/client/gatt.h +++ b/client/gatt.h @@ -21,6 +21,10 @@ * */ +#define MAX_ATTR_VAL_LEN 512 +#define STR_(i) #i +#define STR(i) STR_(i) + void gatt_add_service(GDBusProxy *proxy); void gatt_remove_service(GDBusProxy *proxy); diff --git a/client/main.c b/client/main.c index dd85a1c85..60e0f10b0 100644 --- a/client/main.c +++ b/client/main.c @@ -2013,7 +2013,7 @@ static void cmd_register_characteristic(int argc, char *argv[]) if (check_default_ctrl() == FALSE) return bt_shell_noninteractive_quit(EXIT_FAILURE); - if (argc > 3 && strcmp(argv[3], "authorize")) { + if (argc > 4 && strcmp(argv[4], "authorize")) { bt_shell_printf("Invalid authorize argument\n"); return bt_shell_noninteractive_quit(EXIT_FAILURE); } @@ -2437,14 +2437,15 @@ static const struct bt_shell_menu gatt_menu = { { "unregister-service", "", cmd_unregister_service, "Unregister application service" }, { "register-characteristic", " " - "[authorize]", cmd_register_characteristic, - "Register application characteristic" }, + "[max value len=0(default=" STR(MAX_ATTR_VAL_LEN) ")-" + STR(MAX_ATTR_VAL_LEN) "] [authorize]", + cmd_register_characteristic, + "Register application characteristic" }, { "unregister-characteristic", "", cmd_unregister_characteristic, "Unregister application characteristic" }, - { "register-descriptor", " ", - cmd_register_descriptor, - "Register application descriptor" }, + { "register-descriptor", " [max value len]", + cmd_register_descriptor, "Register application descriptor" }, { "unregister-descriptor", "", cmd_unregister_descriptor, "Unregister application descriptor" }, -- 2.13.6