Return-Path: <linux-bluetooth-owner@vger.kernel.org>
From: Szymon Janc <szymon.janc@codecoup.pl>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] Bluetooth: Fix spurious error message
Date: Wed, 11 Apr 2018 09:33:07 +0200
Message-ID: <1545691.2kjr4zKebi@ix>
In-Reply-To: <20180329094117.25855-1-szymon.janc@codecoup.pl>
References: <20180329094117.25855-1-szymon.janc@codecoup.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi,

On Thursday, 29 March 2018 11:41:17 CEST Szymon Janc wrote:
> This message was debug message before 2064ee332e4c1b7495cf68b. Looks
> like it was changed by accident in that patch. This is causing some
> error messages when doing BR/EDR discovery since Inquiry Command
> generates Command Status event, not Command Complete.
> 
> I'm sending this as RFC for now since while things seem to work fine
> despite this condition (and it was like that for quite some time) it
> feels like this is indeed case that should be handled by HCI request
> code.
> 
> Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
> ---
>  net/bluetooth/hci_event.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index cd3bbb766c24..3f111343f57b 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -5207,8 +5207,7 @@ static bool hci_get_cmd_complete(struct hci_dev *hdev,
> u16 opcode, }
> 
>  	if (hdr->evt != HCI_EV_CMD_COMPLETE) {
> -		bt_dev_err(hdev, "last event is not cmd complete (0x%2.2x)",
> -			   hdr->evt);
> +		BT_DBG("last event is not cmd complete (0x%2.2x)", hdr->evt);
>  		return false;
>  	}

Any thoughts on this?

-- 
pozdrawiam
Szymon Janc