Return-Path: <linux-bluetooth-owner@vger.kernel.org>
MIME-Version: 1.0
In-Reply-To: <20180528082054.4017-1-grzegorz.kolodziejczyk@codecoup.pl>
References: <20180528082054.4017-1-grzegorz.kolodziejczyk@codecoup.pl>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Mon, 28 May 2018 16:39:48 +0300
Message-ID: <CABBYNZLkGWF4wy215sX9_QcsnAT3iYd37KuSwLPZFNooihRm4w@mail.gmail.com>
Subject: Re: [PATCH BlueZ v5 1/4] doc/gatt-api: Add authorization options for attributes
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@codecoup.pl>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Grzegorz,

On Mon, May 28, 2018 at 11:20 AM, Grzegorz Kolodziejczyk
<grzegorz.kolodziejczyk@codecoup.pl> wrote:
> This patch adds authorization property for attributes and prepare write
> request for authorization option for write request. This is require to
> handle correctly prepare writes, which may response with insufficient
> authorization error.
> ---
>  doc/gatt-api.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/doc/gatt-api.txt b/doc/gatt-api.txt
> index 0f1cc9029..2a8da75b0 100644
> --- a/doc/gatt-api.txt
> +++ b/doc/gatt-api.txt
> @@ -85,6 +85,9 @@ Methods               array{byte} ReadValue(dict options)
>                         Possible options: "offset": Start offset
>                                           "device": Device path (Server only)
>                                           "link": Link type (Server only)
> +                                         "prepare-authorize": boolean Is prepare
> +                                                              authorization
> +                                                              request
>
>                         Possible Errors: org.bluez.Error.Failed
>                                          org.bluez.Error.InProgress
> @@ -250,6 +253,7 @@ Properties  string UUID [read-only]
>                                 "encrypt-authenticated-write"
>                                 "secure-read" (Server only)
>                                 "secure-write" (Server only)
> +                               "authorize"
>
>  Characteristic Descriptors hierarchy
>  ====================================
> @@ -284,6 +288,9 @@ Methods             array{byte} ReadValue(dict flags)
>                         Possible options: "offset": Start offset
>                                           "device": Device path (Server only)
>                                           "link": Link type (Server only)
> +                                         "prepare-authorize": boolean Is prepare
> +                                                              authorization
> +                                                              request
>
>                         Possible Errors: org.bluez.Error.Failed
>                                          org.bluez.Error.InProgress
> @@ -321,6 +328,7 @@ Properties  string UUID [read-only]
>                                 "encrypt-authenticated-write"
>                                 "secure-read" (Server Only)
>                                 "secure-write" (Server Only)
> +                               "authorize"
>
>  GATT Profile hierarchy
>  =====================
> --
> 2.13.6

Patches 1-3 applyed, thanks.

-- 
Luiz Augusto von Dentz