Return-Path: MIME-Version: 1.0 In-Reply-To: References: <5a3c473313387957bac050067857e22e62d544f5.camel@iki.fi> <5731aaabb375e5b82945cabff8c315a2ef827cbe.camel@iki.fi> From: =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= Date: Wed, 27 Jun 2018 15:55:05 -0700 Message-ID: Subject: Re: Failure to connect Sony headsets To: Luiz Augusto von Dentz Cc: Tanu Kaskinen , "linux-bluetooth@vger.kernel.org" , General PulseAudio Discussion , =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= , Linux Upstreaming Team Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Wed, Jun 27, 2018 at 1:15 AM, Luiz Augusto von Dentz wrote: > Hi Joao, >> > Ive pushed the fix, at least MW600 reconnects properly. > Thanks, I tested it with my MW600 and it is working great! I'll let you know once I get results from QA with the other headsets. On Wed, Jun 27, 2018 at 12:08 AM, Tanu Kaskinen wrote: > On Tue, 2018-06-26 at 08:41 -0700, Jo=C3=A3o Paulo Rechi Vita wrote: >> My initial thought is that module-card-restore does more harm then >> good for UX with Bluetooth headsets, actually. It sure was useful when >> module-bluetooth-policy did not exist, but I think a good user >> experience is based on dynamically adapting according to which streams >> are active at a certain moment, instead of user input. This is mostly >> covered by module-bluetooth-policy + module-role-{cork,ducking}, but I >> don't think anything switches the profile to A2DP when there is a >> "high-quality" stream playing if module-card-restore initially set the >> profile to headset_head_sink. Maybe this is more of a UI bug and a >> user-focused UI should not expose means for the user to manually >> select the profile, which is aligned with a previous comment from >> Tanu: >> >> > On Thu, Jun 14, 2018 at 4:57 AM, Tanu Kaskinen wrote: >> > >> > If module-bluetooth-policy is sufficient, then module-card-restore >> > won't do anything anyway, because you never set the profile manually. >> > If you ever set the profile manually, that's an indication that module= - >> > bluetooth-policy isn't always good enough. >> >> Still, I think the general user will only manually change the profile >> either if things go wrong for some reason, or before PulseAudio 12, >> because HSP/HFP was selected by default. If they leave the setting on >> the "wrong profile", it affects their experience next time using the >> headset, despite if it is right afterwards or months later, or if the >> headset has been removed and paired with a different machine in the >> meantime. Again, it may be a UI issue after all, but comparing to >> Android/iPhone (which is what a lot of users are likely to have >> previous experience with), there is not even a way for users to >> manually set the active profile for headsets. They can enable/disable >> a profile for an specific headset on Android tho, which gives them >> some sort of control. I don't think there is any client API for >> disabling profiles on cards, but maybe that could be a good >> alternative? > > I agree, it's not nice that setting the profile once will interfere > with automatic configuration forever. Do you want to make a patch for > module-card-restore that adds an option (enabled by default) for > disabling profile restoring for bluetooth? > Yes, I can do it. > Offering a UI for disabling profiles doesn't seem like a better > alternative to me, at least for this problem. If there's some other use > case for disabling profiles, I'm not against the idea in principle. > I was thinking about users that only want to use their headset for HSP/HFP with VoIP applications, for example. But maybe module-stream-restore is enough in this case and I'm over-engineering, lets just leave this case aside for now. -- Jo=C3=A3o Paulo Rechi Vita http://about.me/jprvita