Return-Path: <linux-bluetooth-owner@vger.kernel.org>
From: Szymon Janc <szymon.janc@codecoup.pl>
To: Jagan K <jaganath.k.oss@gmail.com>
Cc: Jaganath Kanakkassery <jaganath.k.os@gmail.com>,
        linux-bluetooth@vger.kernel.org,
        Jaganath Kanakkassery <jaganathx.kanakkassery@intel.com>
Subject: Re: [PATCH v2 00/18] Bluetooth: Extended Adv, Scan, Connection and PHY support
Date: Thu, 21 Jun 2018 11:46:14 +0200
Message-ID: <4540931.1OAoyxkopa@ix>
In-Reply-To: <CAGXVwNZXm=p+oYiSDXg1=wAedU-Tm9v_4kAkcW4_XYUrLnfu4w@mail.gmail.com>
References: <1524577851-17238-1-git-send-email-jaganathx.kanakkassery@intel.com> <1740031.59las4e6Yx@ix> <CAGXVwNZXm=p+oYiSDXg1=wAedU-Tm9v_4kAkcW4_XYUrLnfu4w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi,

On Thursday, 21 June 2018 09:59:17 CEST Jagan K wrote:
> Hi Szymon,
> 
> On Tue, Jun 19, 2018 at 3:25 PM, Szymon Janc <szymon.janc@codecoup.pl> 
wrote:
> > Hi Jaganath,
> > 
> > On Tuesday, 24 April 2018 15:50:33 CEST Jaganath Kanakkassery wrote:
> > > Jaganath Kanakkassery (18):PI for Get, Set PHY Configuration and setting
> > > of PHY in Advertising. Also implemented extended advertising,
> > > scanning and connection.
> > > 
> > > v2: Fixed kbuild warnings
> > > 
> > >   Bluetooth: Introduce helpers for LE set scan start and complete
> > >   Bluetooth: Use extended scanning if controller supports
> > >   Bluetooth: Process extended ADV report event
> > >   Bluetooth: Introduce helpers for le conn status and complete
> > >   Bluetooth: Use extended LE Connection if supported
> > >   Bluetooth: Define PHY flags in hdev and set 1M as default
> > >   Bluetooth: Implement Get PHY Configuration mgmt command
> > >   Bluetooth: Implement Set PHY Confguration command
> > >   Bluetooth: Set Scan PHYs based on selected PHYs by user
> > >   Bluetooth: Handle extended ADV PDU types
> > >   Bluetooth: Use selected PHYs in extended connect
> > >   Bluetooth: Read no of adv sets during init
> > >   Bluetooth: Impmlement extended adv enable
> > >   Bluetooth: Use Set ext adv/scan rsp data if controller supports
> > >   Bluetooth: Implement disable and removal of adv instance
> > >   Bluetooth: Use ext adv for directed adv
> > >   Bluetooth: Implement Set ADV set random address
> > >   Bluetooth: Implement secondary advertising on different PHYs
> > >  
> > >  include/net/bluetooth/hci.h      | 195 ++++++++++++++
> > >  include/net/bluetooth/hci_core.h |  19 ++
> > >  include/net/bluetooth/mgmt.h     |  37 +++
> > >  net/bluetooth/hci_conn.c         | 191 ++++++++++---
> > >  net/bluetooth/hci_core.c         |  29 +-
> > >  net/bluetooth/hci_event.c        | 478 +++++++++++++++++++++++++++-----
> > >  net/bluetooth/hci_request.c      | 568
> > > 
> > > +++++++++++++++++++++++++++++++++------ net/bluetooth/hci_request.h     
> > > |
> > > 
> > >  8 +
> > >  net/bluetooth/hci_sock.c         |   1 +
> > >  net/bluetooth/mgmt.c             | 281 ++++++++++++++++++-
> > >  10 files changed, 1613 insertions(+), 194 deletions(-)
> > 
> > I did some basic tests with Advertising Extension enabled Apache Mynewt
> > controller and it seems like advertising is not re-enabled after
> > disconnection (it is if legacy HCI commands are used).
> 
> Thanks for testing the patches. But i could not reproduce the issue in
> my testing.
> Can you plz provide btmon logs of the issue?

As discussed off-list, controller I tested with supports advertising while 
connected so it was already enabled after connection, not after disconnect.
So all good!

-- 
pozdrawiam
Szymon Janc