Return-Path: From: Ville Syrjala To: linux-bluetooth@vger.kernel.org Cc: Dmitry Torokhov , Greg Kroah-Hartman , Marcel Holtmann , Kay Sievers , =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= , systemd-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Subject: [PATCH v2] hid2hci: Fix udev rules for linux-4.14+ Date: Wed, 20 Jun 2018 19:42:40 +0300 Message-Id: <20180620164240.6535-1-ville.syrjala@linux.intel.com> In-Reply-To: <20180507130638.3516-1-ville.syrjala@linux.intel.com> References: <20180507130638.3516-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: From: Ville Syrjälä Since commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound to a driver") the kernel started emitting "bind" and "unbind" uevents which confuse the hid2hci udev rules. The symptoms on an affected machine (Dell E5400 in my case) include bluetooth devices not appearing and udev hogging the cpu as it's busy processing a constant stream of these "bind"+"unbind" uevents. Change the udev rules not do anything except for "add" and "change" events. This seems to cure my machine at least. v2: Don't mess up "change" (Zbyszek) Fix up the commit message a bit Cc: Dmitry Torokhov Cc: Greg Kroah-Hartman Cc: Marcel Holtmann Cc: Kay Sievers Cc: Zbigniew Jędrzejewski-Szmek Cc: systemd-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Cc: linux-bluetooth@vger.kernel.org Signed-off-by: Ville Syrjälä --- tools/hid2hci.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules index db6bb03d2ef3..5c7208af7a02 100644 --- a/tools/hid2hci.rules +++ b/tools/hid2hci.rules @@ -1,6 +1,6 @@ # do not edit this file, it will be overwritten on update -ACTION=="remove", GOTO="hid2hci_end" +ACTION!="add|change", GOTO="hid2hci_end" SUBSYSTEM!="usb*", GOTO="hid2hci_end" # Variety of Dell Bluetooth devices - match on a mouse device that is -- 2.16.4