Return-Path: Date: Mon, 16 Jul 2018 11:50:18 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, marcel@holtmann.org, johan.hedberg@gmail.com, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Ulf Hansson , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH v5 2/7] serdev: add dev_pm_domain_attach|detach() Message-ID: <20180716095018.GA11078@kroah.com> References: <20180715085628.GI10204@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180715085628.GI10204@localhost> List-ID: On Sun, Jul 15, 2018 at 10:56:28AM +0200, Johan Hovold wrote: > On Mon, Jul 09, 2018 at 11:56:58PM +0800, sean.wang@mediatek.com wrote: > > From: Sean Wang > > > > In order to open up the required power gate before any operation can be > > effectively performed over the serial bus between CPU and serdev, it's > > clearly essential to add common attach functions for PM domains to serdev > > at the probe phase. > > > > Similarly, the relevant dettach function for the PM domains should be > > properly and reversely added at the remove phase. > > > > Signed-off-by: Sean Wang > > Reviewed-by: Ulf Hansson > > Cc: Rob Herring > > Cc: Ulf Hansson > > Cc: Greg Kroah-Hartman > > Cc: Jiri Slaby > > Cc: linux-serial@vger.kernel.org > > Reviewed-by: Johan Hovold Thanks, now applied. greg k-h