Return-Path: Date: Wed, 22 Aug 2018 09:59:50 +0800 From: Fengguang Wu To: Marcel Holtmann , Raghuram Hegde Cc: amit.k.bag@intel.com, raghuram.hegde@intel.com, linux-bluetooth@vger.kernel.org, kbuild-all@01.org, sukumar.ghorai@intel.com, chethan.tumkur.narayan@intel.com, Philip Li Subject: [PATCH] Bluetooth: btintel: fix ptr_ret.cocci warnings Message-ID: <20180822015950.cgvy5wvcdwarka7r@wfg-t540p.sh.intel.com> References: <1534844080-31240-1-git-send-email-raghuram.hegde@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1534844080-31240-1-git-send-email-raghuram.hegde@intel.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Coccinelle warns about drivers/bluetooth/btintel.c:416:1-3: WARNING: PTR_ERR_OR_ZERO can be used Fix it by using PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 38ca310b0d2c ("Bluetooth: btintel: Add platform device for rfkill signal") CC: Sukumar Ghorai Signed-off-by: Fengguang Wu --- btintel.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -413,10 +413,7 @@ static int btintel_probe(struct platform reset_gpio_handler = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(reset_gpio_handler)) - return PTR_ERR(reset_gpio_handler); - - return 0; + return PTR_ERR_OR_ZERO(reset_gpio_handler); } static int btintel_remove(struct platform_device *pdev) _______________________________________________ kbuild-all mailing list kbuild-all@lists.01.org https://lists.01.org/mailman/listinfo/kbuild-all