DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BEAD21571
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: Re: [PATCH] ath3k: add warning when switch pid is not working
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20180907233549.GE3379@giustizia.org>
Date:   Thu, 27 Sep 2018 12:48:17 +0200
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <BE213F03-E020-4046-BF60-8723902BCD71@holtmann.org>
References: <20180907233549.GE3379@giustizia.org>
To:     Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Luiz,

> This patch adds a warning message in the ath3k driver when
> ath3k_switch_pid() returns error.
> 
> This event happens in a specific laptop, with an adapter which
> identifies itself as 0cf3:0036. Surprisingly, the adapter works even
> after this event - hence a warning is chosen instead of an error.
> 
> The current version of ath3k doesn't check the return value of
> ath3k_switch_pid() and so this event may remain undetected in the
> original version.

if works anyway, why bother with a warning? I have no idea what benefit this has.

Regards

Marcel