DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFD12216FE
Date:   Thu, 27 Sep 2018 13:15:13 -0300
From:   Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] ath3k: add warning when switch pid is not working
Message-ID: <20180927161513.GD23822@giustizia.org>
References: <20180907233549.GE3379@giustizia.org>
 <BE213F03-E020-4046-BF60-8723902BCD71@holtmann.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BE213F03-E020-4046-BF60-8723902BCD71@holtmann.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi, Marcel,

On Thu, Sep 27, 2018 at 12:48:17PM +0200, Marcel Holtmann wrote:
> Hi Luiz,
> 
> > This patch adds a warning message in the ath3k driver when
> > ath3k_switch_pid() returns error.
> > 
> > This event happens in a specific laptop, with an adapter which
> > identifies itself as 0cf3:0036. Surprisingly, the adapter works even
> > after this event - hence a warning is chosen instead of an error.
> > 
> > The current version of ath3k doesn't check the return value of
> > ath3k_switch_pid() and so this event may remain undetected in the
> > original version.
> 
> if works anyway, why bother with a warning? I have no idea what benefit this has.
> 

I analyze this issue as having three possible cases:

(1) the function works, and so, no problems, no warnings;

(2) (my case) the function fails but the system works as it should do;
in this case I would agree with you, but

(3) the function fails and this affects the whole system (let's say, the
VID:PID doesn't change as intended); in this case there's a problem and
the admin should be in a better position if one can be watched by this
warning.

Based on the code, there's no way to diferentiate (2) and (3), so IMHO a
warning would be justified.


Best regards,

Luiz