DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D949216E3
Date:   Thu, 27 Sep 2018 17:13:50 -0300
From:   Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] ath3k: add more information to error message
Message-ID: <20180927201350.GA19318@giustizia.org>
References: <20180907233603.GF3379@giustizia.org>
 <5CF8F067-C9A1-4028-847A-0B25DB00F61A@holtmann.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5CF8F067-C9A1-4028-847A-0B25DB00F61A@holtmann.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi, Marcel,


On Thu, Sep 27, 2018 at 12:47:11PM +0200, Marcel Holtmann wrote:
> Hi Luiz,
> 
> > When there is an error in either ath3k_load_firmware() or
> > ath3k_load_fwfile(), the inlined function ath3k_log_failed_loading() is
> > called receiving the error returned and both the block size requested to
> > load and the size actually loaded. These values are printed in an error
> > message using the macro BT_ERR.
> > 
> > This patch creates a new function which does the same but also receives
> > the "count" variable, in order to show more information when a failing
> > firmware loading happens. The calls to the older function were changed
> > to the new one.
> > 
> > This event is being monitored in a laptop with an adapter which
> > identifies itself as 0cf3:0036, where sometimes there are errors in the
> > firmware loading process.
> > 
> > Signed-off-by: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
> > ---
> > drivers/bluetooth/ath3k.c | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > index 3a8c47efea55..ebc312cb4412 100644
> > --- a/drivers/bluetooth/ath3k.c
> > +++ b/drivers/bluetooth/ath3k.c
> > @@ -209,6 +209,14 @@ static inline void ath3k_log_failed_loading(int err, int len, int size)
> > 			err, len, size);
> > }
> > 
> > +static inline void ath3k_log_failed_loading_2(int err, int len, int size,
> > +						int count)
> > +{
> > +	BT_ERR("%s err = %d, len = %d, size = %d, count = %d",
> > +			"Error in firmware loading",
> > +			err, len, size, count);
> > +}
> > +
> 
> just change the the original ath3k_log_failed_loading to include the count parameter.
> 

Ok, fine. I'll send it in a next message.

Many thanks,

Luiz